Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin node-fetch version temporarily #870

Merged
merged 5 commits into from Sep 22, 2021
Merged

Pin node-fetch version temporarily #870

merged 5 commits into from Sep 22, 2021

Conversation

luisherranz
Copy link
Member

@luisherranz luisherranz commented Sep 21, 2021

What:

Temporarily pin the version of node-fetch to 2.6.2. Fixes #868.

Why:

Because node-fetch introduced a problem with an import in the 2.6.3 version that is breaking Frontity.

How:

By removing the ^ of the version number for now.

Tasks:

Unrelated Tasks

  • Code
  • TSDocs
  • TypeScript
  • Unit tests
  • End to end tests
  • TypeScript tests
  • Update starter themes
  • Update other packages
  • Update community discussions

Additional Comments

Thanks to @robrecord for the catch 馃檪

@changeset-bot
Copy link

changeset-bot bot commented Sep 21, 2021

馃 Changeset detected

Latest commit: d05c1da

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@robrecord
Copy link

robrecord commented Sep 21, 2021

You're welcome! And thanks for the fix.

By the way, node-fetch just created a patch for this which is waiting for confirmation as they cannot reproduce. I am not yet sure how I can validate this patch with frontity but I will try.

Once confirmed, they can publish it and we can then release the constraint on this version.

I will confirm on my end if I can; if you have a chance to confirm also that would be very helpful.

@luisherranz
Copy link
Member Author

Thanks @robrecord. If tests pass I think we can merge and release this so we don't depend on when node-fetch merges and releases their fix.

@luisherranz luisherranz marked this pull request as ready for review September 21, 2021 16:35
Copy link
Member

@michalczaplinski michalczaplinski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 馃憤

@luisherranz
Copy link
Member Author

Thanks Michal!

@luisherranz luisherranz merged commit e3f947e into dev Sep 22, 2021
@luisherranz luisherranz deleted the pin-node-fetch-version branch September 22, 2021 07:19
@SantosGuillamot SantosGuillamot mentioned this pull request Sep 22, 2021
@sainer
Copy link

sainer commented Sep 22, 2021

Instructions for for less experienced users.

  1. Find in your project node_modules folder package named frontity.
  2. In frontity folder there is package.json file. Edit it.
  3. Find in dependencies node-fetch package. Change its value to "2.6.2" (without ^ sign). Save file.
  4. Run npm update in your root project folder

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't import the named export 'URL' from non EcmaScript module (only default export is available)
4 participants