Merge pull request #870 from frontity/pin-node-fetch-version

Pin node-fetch version temporarily
frontity · Sep 22, 2021 · e3f947e · e3f947e
2 parents ab39dbc + d05c1da
commit e3f947e
Show file tree

Hide file tree

Showing 10 changed files with 4,128 additions and 4,108 deletions.
diff --git a/.changeset/wild-suns-worry.md b/.changeset/wild-suns-worry.md
@@ -0,0 +1,6 @@
+---
+"frontity": patch
+"@frontity/wp-source": patch
+---
+
+Pin `node-fetch` version until they solve [the import problem](https://github.com/node-fetch/node-fetch/pull/1303) introduced in v2.6.3. Thanks to @robrecord for the catch.
diff --git a/e2e/package-lock.json b/e2e/package-lock.json
diff --git a/e2e/package.json b/e2e/package.json
@@ -35,7 +35,7 @@
     "http-server": "^0.12.3",
     "minimist": "^1.2.5",
     "node-env-run": "^4.0.2",
-    "node-fetch": "^2.6.1",
+    "node-fetch": "2.6.2",
     "selenium-side-runner": "^3.17.0",
     "wait-on": "^5.2.1",
     "wdio-chromedriver-service": "^7.0.0"

diff --git a/package-lock.json b/package-lock.json
diff --git a/packages/components/__tests__/image.jsdom.tests.tsx b/packages/components/__tests__/image.jsdom.tests.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 /* eslint-disable @typescript-eslint/no-empty-function */
 /* eslint-disable no-global-assign */
 
@@ -15,6 +16,7 @@ jest.mock("@frontity/hooks/use-in-view", () => ({
 
 // Mock only useConnect in the 'frontity' module
 jest.mock("frontity", () => ({
+  // @ts-ignore
   ...jest.requireActual("frontity"),
   useConnect: () => ({
     state: {

diff --git a/packages/components/__tests__/image.node.tests.tsx b/packages/components/__tests__/image.node.tests.tsx
@@ -1,3 +1,5 @@
+/* eslint-disable @typescript-eslint/ban-ts-comment */
+
 /**
  * @jest-environment node
  */
@@ -7,6 +9,7 @@ import Image from "../image";
 
 // Mock only useConnect in the 'frontity' module
 jest.mock("frontity", () => ({
+  // @ts-ignore
   ...jest.requireActual("frontity"),
   useConnect: () => ({
     state: {

diff --git a/packages/components/link/__tests__/link.tests.tsx b/packages/components/link/__tests__/link.tests.tsx
@@ -1,3 +1,4 @@
+/* eslint-disable @typescript-eslint/ban-ts-comment */
 import { render, unmountComponentAtNode } from "react-dom";
 import { act } from "react-dom/test-utils";
 import { create } from "react-test-renderer";
@@ -547,6 +548,7 @@ describe("Link prefetching", () => {
     get.mockReturnValue({ isReady: false, isFetching: false });
     jest.spyOn(store.actions.source, "fetch");
     // simulate save data mode
+    // @ts-ignore
     (navigator as Navigator & { connection }).connection = { saveData: true };
     act(() => {
       render(
@@ -562,6 +564,7 @@ describe("Link prefetching", () => {
     expect(store.actions.source.fetch).toHaveBeenCalledTimes(0);
     expect(store.actions.source.fetch).not.toHaveBeenCalledWith(linkUrl1);
 
+    // @ts-ignore
     (navigator as Navigator & { connection }).connection = { saveData: false };
   });
 

diff --git a/packages/components/link/utils.ts b/packages/components/link/utils.ts
@@ -184,7 +184,7 @@ export const shouldFetchLink = (link: string) => {
   /**
    * Checks if user is on slow connection or has enabled data saver.
    */
-  const _navigator = window.navigator as NavigatorWithConnection;
+  const _navigator = window.navigator as unknown as NavigatorWithConnection;
 
   const isSlowConnection =
     _navigator?.connection?.saveData ||

diff --git a/packages/frontity/package.json b/packages/frontity/package.json
@@ -58,7 +58,7 @@
     "inquirer": "^7.3.3",
     "is-root": "^2.1.0",
     "leven": "^3.1.0",
-    "node-fetch": "^2.6.1",
+    "node-fetch": "2.6.2",
     "ora": "^5.1.0",
     "ramda": "^0.27.1",
     "react-helmet-async": "^1.0.9",

diff --git a/packages/wp-source/package.json b/packages/wp-source/package.json
@@ -30,6 +30,6 @@
   "devDependencies": {
     "@frontity/connect": "^1.3.0",
     "clone-deep": "^4.0.1",
-    "node-fetch": "^2.6.1"
+    "node-fetch": "2.6.2"
   }
 }