Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Add tests for ConfigResolver #248

Merged
merged 1 commit into from
May 18, 2022

Conversation

localheinz
Copy link
Collaborator

This pull request

  • adds tests for the ConfigResolver

Related to #247.

@localheinz localheinz changed the title Fix: Add tests for ConfigResolver Fix: Add tests for ConfigResolver May 18, 2022
Comment on lines +146 to +152
[
'.twig_cs',
[
'.twigcs',
'.twigcs.dist',
],
],
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciloe @OwlyCode @yguedidi

In the context of #247, we could add more data sets here to ensure that configuration files are resolved in the specified order - what do you think?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, I'll rework my PR when this is merged

Comment on lines +279 to +280
'.twig_cs',
'.twig_cs.dist',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Ciloe @OwlyCode @yguedidi

In the context of #247, we could add more data sets here to ensure that these default configuration files are resolved - what do you think?

@localheinz localheinz requested review from Ciloe and OwlyCode May 18, 2022 12:58
@localheinz localheinz merged commit 47e4559 into friendsoftwig:main May 18, 2022
@localheinz localheinz deleted the fix/config-resolver branch May 18, 2022 20:11
@localheinz
Copy link
Collaborator Author

Thank you, @yguedidi!

@Ciloe
Copy link
Collaborator

Ciloe commented May 19, 2022

Many thanks :)

This was referenced May 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants