New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for config files with .php
extension
#247
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good, but check tests ?
Looks good to me! Can we keep the test on the old convention until we release the BC break to remove it? |
Codecov Report
@@ Coverage Diff @@
## main #247 +/- ##
============================================
+ Coverage 79.00% 79.02% +0.01%
Complexity 749 749
============================================
Files 55 55
Lines 2410 2412 +2
============================================
+ Hits 1904 1906 +2
Misses 506 506
Continue to review full report at Codecov.
|
.php
extension
@localheinz looks like a good plan! I should have added tests for the ConfigResolver in the first place 😅 |
5cd71c7
to
61349a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
thank you @localheinz for the update! |
Sounds good, let me adjust! |
63086bf
to
33888b3
Compare
f71009e
to
47dd306
Compare
- `.twig_cs.php` | ||
- `.twig_cs` | ||
- `.twig_cs.dist.php` | ||
- `.twig_cs.dist` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have turned this into a list, making the order perhaps a bit more clear. What do you think?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Indeed better!
Do you want to prepare a release later? |
Fixes #246
Better reviewed commit by commit