Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: update to node v16 with npm v6 for packaging #4092

Merged
merged 15 commits into from May 10, 2022
Merged
Show file tree
Hide file tree
Changes from 5 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .circleci/config.yml
Expand Up @@ -25,7 +25,7 @@ parameters:
default: '3.13.1'
node-version:
type: string
default: '14.16.0'
default: '16.13.0'
# Constants
cache-version:
type: string
Expand Down Expand Up @@ -382,7 +382,7 @@ jobs:
command: |
[xml]$results = Get-Content junit-aggregate.xml
$failure = $results.SelectSingleNode("//failure")
if ($failure -ne $null) {
if ($failure -ne $null) {
Write-Host "Forcing build failure due to test failure(s) :'("
$host.SetShouldExit(1)
}
Expand Down
5 changes: 2 additions & 3 deletions .github/workflows/create-release-branch.yml
Expand Up @@ -7,14 +7,14 @@ on:
jobs:
create_branch:
name: 'Create Branch'

runs-on: ubuntu-latest

steps:
- name: Setup Node.js
uses: actions/setup-node@v1
with:
node-version: '14.16.x'
node-version: '16.13.x'
- name: Checkout
uses: actions/checkout@v2.0.0
with:
Expand Down Expand Up @@ -43,4 +43,3 @@ jobs:
# -H 'Authorization: Bearer ${{ secrets.SLACK_BOT_TOKEN }}' \
# -X POST -d "${{ github.event.client_payload.on_success }}" \
# https://slack.com/api/chat.update

14 changes: 11 additions & 3 deletions .npmrc
@@ -1,5 +1,13 @@
#save exact versions of dependencies from the package.json
# https://docs.npmjs.com/cli/v8/using-npm/config

# Save dependencies to package.json with an exact version rather than using npm's default semver range operator
save-exact=true

#enforces usage of the minimum node version in our .nvmrc
engine-strict=true
# Refuse to install (or even consider installing) any package that claims to not be compatible with the current Node.js version.
engine-strict=true

# If a package cannot be installed because of overly strict peerDependencies that collide, it provides a way to move forward resolving the situation.
# TODO (debug):
# npm ERR! While resolving: salesforcedx-vscode-soql@54.8.0
# npm ERR! Found: @typescript-eslint/parser@3.10.1
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it suggest a version that works or what?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Modified the peer/dev deps to match the versions and removed the legacy peer deps flag

legacy-peer-deps=true
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
v14.16.0
v16.13.0
4 changes: 2 additions & 2 deletions contributing/developing.md
Expand Up @@ -2,7 +2,7 @@

## Pre-requisites

1. We are requiring Node 14 at a minimum. If you need to work with multiple versions of Node, you
1. We are requiring Node 16 at a minimum. If you need to work with multiple versions of Node, you
might consider using [nvm](https://github.com/creationix/nvm).
1. This repository uses [Lerna](https://lernajs.io/) to manage it as a
_monorepo_. Please install Lerna globally using `npm install --global lerna`.
Expand Down Expand Up @@ -208,4 +208,4 @@ The npmrc allows for project-level [configuration](https://docs.npmjs.com/cli/v8

### .nvmrc

Our nvmrc specifies the minimimum node version required to run the project.
Our nvmrc specifies the minimum node version required to run the project.