build: update to node v16 with npm v6 for packaging #4092

mohanraj-r · 2022-05-09T21:56:01Z

What does this PR do?

Update to node 16
- with npm 6 for packaging as vsce packaging doesn't work with
  - npm v8 / v7 (even on node 14) - packaging errors
  - yarn classic / berry (with legacy node_modules) - packaging doesn't error but doesn't produce valid working extensions (Created VSIX via vsce package --yarn does not include not-hoisted deep dependency microsoft/vscode-vsce#432)
Adds npm script to install locally built vsix files into insiders
Follows up on build(salesforcedx-vscode): update node to v16 and switch from npm to yarn #4042 (and build(salesforcedx-vscode): update node to v16 and npm v8 #4067)

TODO

Debug missing peer deps (stretch)
rename vscode:install to vsix:install
eval if lerna bootstrap is needed with npm workspaces?
better to specify lockfile version in npmrc?
vsix ctv install check

What issues does this PR fix or reference?

@W-11004197@

Functionality Before

Node 14, npm6 was used with lockfile version 1
No workspaces: lock file didn't correctly account for all dependencies in the packages in the mono-repo

Functionality After

Node 16, npm 6 declared as a dependency and used by vsce packaging
Uses lockfile version 2 (npm 8) with better resolution
Uses workspaces with lockfile accounting for all deps in the mono-repo
lerna bootstrap is still used in post install as npm install --workspaces [--include-workspace-root] errors during arch specific node install
lerna is still used to run scripts instead of using npm run --workspaces due to [BUG] Unexpected, recursive workspace script calls npm/cli#4603

as npm 7/8 breaks vsce packaging

mohanraj-r · 2022-05-10T02:57:29Z

Bundle size validity

node 14, npm 6

baseline on develop@54.12.0 (ff49172)
Installed size: 795M

3.7M    ./packages/salesforcedx-vscode-visualforce/salesforcedx-vscode-visualforce-54.12.0.vsix
7.3M    ./packages/salesforcedx-vscode-apex-replay-debugger/salesforcedx-vscode-apex-replay-debugger-54.12.0.vsix
 26M    ./packages/salesforcedx-vscode-core/salesforcedx-vscode-core-54.12.0.vsix
 23M    ./packages/salesforcedx-vscode-apex/salesforcedx-vscode-apex-54.12.0.vsix
1.2M    ./packages/salesforcedx-vscode-apex-debugger/salesforcedx-vscode-apex-debugger-54.12.0.vsix
 32M    ./packages/salesforcedx-vscode-lwc/salesforcedx-vscode-lwc-54.12.0.vsix
5.5M    ./packages/salesforcedx-vscode-soql/salesforcedx-vscode-soql-54.12.0.vsix
 16K    ./packages/salesforcedx-vscode-expanded/salesforcedx-vscode-expanded-54.12.0.vsix
 24K    ./packages/salesforcedx-vscode/salesforcedx-vscode-54.12.0.vsix
8.8M    ./packages/salesforcedx-vscode-lightning/salesforcedx-vscode-lightning-54.12.0.vsix

node 16, npm 6 without Workspaces and lockfile v2:

Installed size: 795M

3.9M    ./packages/salesforcedx-vscode-visualforce/salesforcedx-vscode-visualforce-54.12.0.vsix
7.3M    ./packages/salesforcedx-vscode-apex-replay-debugger/salesforcedx-vscode-apex-replay-debugger-54.12.0.vsix
 25M    ./packages/salesforcedx-vscode-core/salesforcedx-vscode-core-54.12.0.vsix
 23M    ./packages/salesforcedx-vscode-apex/salesforcedx-vscode-apex-54.12.0.vsix
1.2M    ./packages/salesforcedx-vscode-apex-debugger/salesforcedx-vscode-apex-debugger-54.12.0.vsix
 32M    ./packages/salesforcedx-vscode-lwc/salesforcedx-vscode-lwc-54.12.0.vsix
5.7M    ./packages/salesforcedx-vscode-soql/salesforcedx-vscode-soql-54.12.0.vsix
 16K    ./packages/salesforcedx-vscode-expanded/salesforcedx-vscode-expanded-54.12.0.vsix
 24K    ./packages/salesforcedx-vscode/salesforcedx-vscode-54.12.0.vsix
9.1M    ./packages/salesforcedx-vscode-lightning/salesforcedx-vscode-lightning-54.12.0.vsix

node 16, npm 6 with Workspaces and lockfile v2:

Installed size: 796M

3.8M    ./packages/salesforcedx-vscode-visualforce/salesforcedx-vscode-visualforce-54.12.0.vsix
7.3M    ./packages/salesforcedx-vscode-apex-replay-debugger/salesforcedx-vscode-apex-replay-debugger-54.12.0.vsix
 25M    ./packages/salesforcedx-vscode-core/salesforcedx-vscode-core-54.12.0.vsix
 23M    ./packages/salesforcedx-vscode-apex/salesforcedx-vscode-apex-54.12.0.vsix
1.3M    ./packages/salesforcedx-vscode-apex-debugger/salesforcedx-vscode-apex-debugger-54.12.0.vsix
 32M    ./packages/salesforcedx-vscode-lwc/salesforcedx-vscode-lwc-54.12.0.vsix
5.5M    ./packages/salesforcedx-vscode-soql/salesforcedx-vscode-soql-54.12.0.vsix
 16K    ./packages/salesforcedx-vscode-expanded/salesforcedx-vscode-expanded-54.12.0.vsix
 24K    ./packages/salesforcedx-vscode/salesforcedx-vscode-54.12.0.vsix
8.8M    ./packages/salesforcedx-vscode-lightning/salesforcedx-vscode-lightning-54.12.0.vsix

node 16, npm 6 with Workspaces and lockfile v3:

Installed size: 796M

3.3M    ./packages/salesforcedx-vscode-visualforce/salesforcedx-vscode-visualforce-54.12.0.vsix
7.5M    ./packages/salesforcedx-vscode-apex-replay-debugger/salesforcedx-vscode-apex-replay-debugger-54.12.0.vsix
 25M    ./packages/salesforcedx-vscode-core/salesforcedx-vscode-core-54.12.0.vsix
 23M    ./packages/salesforcedx-vscode-apex/salesforcedx-vscode-apex-54.12.0.vsix
1.3M    ./packages/salesforcedx-vscode-apex-debugger/salesforcedx-vscode-apex-debugger-54.12.0.vsix
 31M    ./packages/salesforcedx-vscode-lwc/salesforcedx-vscode-lwc-54.12.0.vsix
5.7M    ./packages/salesforcedx-vscode-soql/salesforcedx-vscode-soql-54.12.0.vsix
 16K    ./packages/salesforcedx-vscode-expanded/salesforcedx-vscode-expanded-54.12.0.vsix
 24K    ./packages/salesforcedx-vscode/salesforcedx-vscode-54.12.0.vsix
8.8M    ./packages/salesforcedx-vscode-lightning/salesforcedx-vscode-lightning-54.12.0.vsix

…all deps in the monorepo

…iders

package.json

gbockus-sf · 2022-05-10T04:49:12Z

.npmrc

+# TODO (debug):
+#   npm ERR! While resolving: salesforcedx-vscode-soql@54.8.0
+#   npm ERR! Found: @typescript-eslint/parser@3.10.1


does it suggest a version that works or what?

Modified the peer/dev deps to match the versions and removed the legacy peer deps flag

gbockus-sf

Thanks Mohan. Glad you finally peeled the onion :)

… deps config

…ter installs from 2.9M to 1.6M

…instead of removing it

contributing/developing.md

…ke3' into mohanraj-r/node16_npm8_update_take3

Mohan Raj Rajamanickam added 3 commits May 9, 2022 14:19

ci: update to node v16 from node v14

ec89666

build: update package lock to v2

f1880d5

build: update package engine and deps to node 16 with npm 6

1636411

as npm 7/8 breaks vsce packaging

mohanraj-r mentioned this pull request May 10, 2022

build(salesforcedx-vscode): update node to v16 and switch from npm to yarn #4042

Closed

68 tasks

mohanraj-r added 2 commits May 9, 2022 20:06

build: enable npm workspaces; thus updating lock file to account for …

be729ae

…all deps in the monorepo

build: add npm script to install locally built vsix packages into ins…

2dd0eca

…iders

mohanraj-r marked this pull request as ready for review May 10, 2022 03:40

mohanraj-r requested a review from a team as a code owner May 10, 2022 03:40

mohanraj-r requested review from klewis-sfdc and gbockus-sf May 10, 2022 03:40

mohanraj-r changed the title ~~build: update to node v16 from node v14~~ build: update to node v16 with npm v6 for packaging May 10, 2022

gbockus-sf reviewed May 10, 2022

View reviewed changes

package.json Outdated Show resolved Hide resolved

gbockus-sf reviewed May 10, 2022

View reviewed changes

gbockus-sf approved these changes May 10, 2022

View reviewed changes

mohanraj-r added 7 commits May 9, 2022 22:13

docs: add info about new pkgs install script

d6140d1

build: fix mismatch peer dep versions in soql pkg; remove legacy peer…

c757794

… deps config

refactor: rename vscode:install to vsix:install

a85953b

build: switch to lock file v3 for reduced file size and hopefully fas…

c88c38f

…ter installs from 2.9M to 1.6M

refactor: npm run scripts to reuse targets

c37cb5d

refactor: reinstall script to use git checkout to reset package lock …

347e6f0

…instead of removing it

docs: add info about npm v6 vs npm v8

5eb7b17

gbockus-sf reviewed May 10, 2022

View reviewed changes

contributing/developing.md Show resolved Hide resolved

mohanraj-r and others added 3 commits May 10, 2022 13:07

Merge branch 'develop' into mohanraj-r/node16_npm8_update_take3

03d6914

docs: add info about legacy circle image and node version

65eb8c5

Merge remote-tracking branch 'origin/mohanraj-r/node16_npm8_update_ta…

172eaad

…ke3' into mohanraj-r/node16_npm8_update_take3

mohanraj-r merged commit 191cfce into develop May 10, 2022

mohanraj-r deleted the mohanraj-r/node16_npm8_update_take3 branch May 10, 2022 21:00

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

build: update to node v16 with npm v6 for packaging #4092

build: update to node v16 with npm v6 for packaging #4092

mohanraj-r commented May 9, 2022 •

edited

mohanraj-r commented May 10, 2022 •

edited

gbockus-sf May 10, 2022

mohanraj-r May 10, 2022 •

edited

gbockus-sf left a comment

build: update to node v16 with npm v6 for packaging #4092

build: update to node v16 with npm v6 for packaging #4092

Conversation

mohanraj-r commented May 9, 2022 • edited

What does this PR do?

TODO

What issues does this PR fix or reference?

Functionality Before

Functionality After

mohanraj-r commented May 10, 2022 • edited

Bundle size validity

node 14, npm 6

node 16, npm 6 without Workspaces and lockfile v2:

node 16, npm 6 with Workspaces and lockfile v2:

node 16, npm 6 with Workspaces and lockfile v3:

gbockus-sf May 10, 2022

Choose a reason for hiding this comment

mohanraj-r May 10, 2022 • edited

Choose a reason for hiding this comment

gbockus-sf left a comment

Choose a reason for hiding this comment

mohanraj-r commented May 9, 2022 •

edited

mohanraj-r commented May 10, 2022 •

edited

mohanraj-r May 10, 2022 •

edited