New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
COLRv2 #3244
Open
behdad
wants to merge
9
commits into
main
Choose a base branch
from
colrv2
base: main
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 046434c. Discarding the idea. Didn't save any.
Copying templatization results from googlefonts/colr-gradients-spec#371 (comment): The savings unfortunately are meager. It saves 2.84% of the COLR table size, which translates to only 0.63% of the total font. This is expected since most glyphs do not templatize in a full emoji repertoire. Here's the tools output:
|
For
cc @simoncozens |
behdad
force-pushed
the
colrv2
branch
3 times, most recently
from
August 6, 2023 02:06
fb57110
to
fa67832
Compare
Implements extended version of: googlefonts/colr-gradients-spec#370
Otherwise it messes up templatizing...
A font I'm testing with has that for the empty space glyph...
Increases savings from 2.88% to 3.2% in COLR table of NotoColorEmoji.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This branch implements various proposed paints for COLRv2.
Currently it has PaintTemplate's:
googlefonts/colr-gradients-spec#371
And
PaintGlyphSelf
/PaintGlyphDelta
:googlefonts/colr-gradients-spec#370
HarfBuzz counterpart: harfbuzz/harfbuzz#4363