Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set tab order when document is tagged #1449

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Set tab order when document is tagged #1449

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
dcffcda
Set tab order when document is tagged
acrollet May 23, 2023
1c9ce2c
Update approach and add inverse test
acrollet May 25, 2023
3b82e0e
Revert page dictionary setup
acrollet May 25, 2023
31b505e
Update lib/mixins/markings.js
acrollet May 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
Binary file modified examples/kitchen-sink-accessible.pdf
View file
Open in desktop
Binary file not shown.
4 changes: 4 additions & 0 deletions lib/mixins/markings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,10 @@ export default {
return this._root.data.MarkInfo;
},

hasMarkInfoDictionary() {
return Object.prototype.hasOwnProperty.call(this._root.data, 'MarkInfo');
acrollet marked this conversation as resolved.
Show resolved Hide resolved
acrollet marked this conversation as resolved.
Show resolved Hide resolved
},

getStructTreeRoot() {
if (!this._root.data.StructTreeRoot) {
this._root.data.StructTreeRoot = this.ref({
Expand Down
8 changes: 8 additions & 0 deletions lib/page.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,15 @@ class PDFPage {
return this.content.write(chunk);
}

// Set tab order if document is tagged for accessibility.
_setTabOrder() {
if (!this.dictionary.Tabs && this.document.hasMarkInfoDictionary()) {
this.dictionary.data.Tabs = 'S';
}
}
acrollet marked this conversation as resolved.
Show resolved Hide resolved

end() {
this._setTabOrder();
this.dictionary.end();
this.resources.end();
return this.content.end();
Expand Down
41 changes: 41 additions & 0 deletions tests/unit/markings.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -623,6 +623,47 @@ EMC
`(My Title)`,
`endobj`
]);
expect(docData).toContainChunk([
`10 0 obj`,
/\/Tabs \/S/,
`endobj`
]);
});
});

describe('untagged document', () => {
test('taborder not set for unmarked content', () => {
document = new PDFDocument({
info: {
CreationDate: new Date(Date.UTC(2018, 1, 1)),
Title: "My Title"
},
displayTitle: true,
compress: false,
pdfVersion: '1.5',
tagged: false,
lang: 'en-AU'
});

const docData = logData(document);

document.end();

expect(docData).toContainChunk([
`3 0 obj`,
/\/Lang \(en-AU\)/,
`endobj`
]);
expect(docData).not.toContainChunk([
`3 0 obj`,
/\/MarkInfo 5 0 R/,
`endobj`
]);
expect(docData).not.toContainChunk([
`10 0 obj`,
/\/Tabs \/S/,
`endobj`
]);
});
});

Expand Down