New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set tab order when document is tagged #1449
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@acrollet , firstly, let me say thanks for putting this together. Despite being simple, I hadn't managed to look at it, and having something concrete to look at is really helpful. This is certainly put together well, and it's good to see that it's tested. For a couple of reasons I'll explain inline, I think a slightly different approach would be preferable, though. I think it should be easy to adjust, if you can spare a little more time for this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @acrollet , overall, this looks great. There's nothing wrong with it, so I'm happy to give an approving review. I've left a comment inline, however, suggesting simplifying a condition, which also makes it more consistent with nearby code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding suggestion
@blikblum , I'm happy for this to be merged if you are, or would you like @liborm85 or @devongovett to give it a review as well? |
|
Hi folks, just wondering if there's anything else needed on this PR. Thanks! 🙂 |
@blikblum @insightfuls just wondering if there's anything else needed or if this could be merged? Thanks! |
Changes
fixes #1260
relates to department-of-veterans-affairs/va.gov-team#58587
This PR sets tab order to "Structure" when a document is tagged.