New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add default arguments to AnimatedPhysicalModel
#147424
Merged
auto-submit
merged 11 commits into
flutter:master
from
nate-thegrate:animatedphysicalmodel-default-argument
May 2, 2024
Merged
Changes from 10 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
3ba9eb0
add default argument
nate-thegrate 0f3fbd2
add new test!
nate-thegrate e788978
whitespace
nate-thegrate 61c6aad
change year
nate-thegrate 49f1a80
update test
nate-thegrate da8507d
add another default arg :)
nate-thegrate d58f0e7
move test into implicit_animations_test.dart
nate-thegrate 1c71e10
Merge branch 'master' into animatedphysicalmodel-default-argument
nate-thegrate 1b307be
fix analysis problem
nate-thegrate 625a9c5
make AnimatedPhysicalModel.borderRadius nullable to match non-animate…
nate-thegrate df1494b
Merge branch 'master' into animatedphysicalmodel-default-argument
nate-thegrate File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why remove the explicit default value for borderRadius?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The non-animated class has a nullable border radius, so this change makes them consistent.