Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add default arguments to AnimatedPhysicalModel #147424

Merged
merged 11 commits into from May 2, 2024
Merged

Add default arguments to AnimatedPhysicalModel #147424

merged 11 commits into from May 2, 2024
+49 −11

Conversation

nate-thegrate
Copy link
Member

@nate-thegrate nate-thegrate commented Apr 26, 2024 •
edited

Currently, PhysicalModel has default arguments for shape and elevation, but AnimatedPhysicalModel does not.

This pull request makes both classes consistent.

@github-actions github-actions bot added framework flutter/packages/flutter repository. See also f: labels. a: animation Animation APIs f: material design flutter/packages/flutter/material repository. labels Apr 26, 2024
@nate-thegrate nate-thegrate marked this pull request as draft April 26, 2024 17:38
@Hixie
Copy link
Contributor

Hixie commented Apr 26, 2024

We should still test this, ideally (checking that there is a default and that it's the one we expect).

@nate-thegrate nate-thegrate marked this pull request as ready for review April 26, 2024 17:53
@nate-thegrate nate-thegrate changed the title Add default argument to AnimatedPhysicalModel Add default arguments to AnimatedPhysicalModel Apr 27, 2024
goderbauer
goderbauer reviewed Apr 29, 2024
View reviewed changes
packages/flutter/lib/src/widgets/implicit_animations.dart
this.clipBehavior = Clip.none,
this.borderRadius = BorderRadius.zero,
required this.elevation,
this.borderRadius,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why remove the explicit default value for borderRadius?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The non-animated class has a nullable border radius, so this change makes them consistent.

goderbauer
goderbauer approved these changes Apr 29, 2024
View reviewed changes
Copy link
Member

@goderbauer goderbauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nate-thegrate
Copy link
Member Author

Guess who's able to add labels now 😎😎😎

@nate-thegrate nate-thegrate added the autosubmit Merge PR when tree becomes green via auto submit App label May 2, 2024
@auto-submit auto-submit bot merged commit 7436cc2 into flutter:master May 2, 2024
73 checks passed
@nate-thegrate nate-thegrate deleted the animatedphysicalmodel-default-argument branch May 2, 2024 21:59
@goderbauer
Copy link
Member

Guess who's able to add labels now 😎😎😎

🥳 Welcome to flutter-hackers!

@engine-flutter-autoroll engine-flutter-autoroll mentioned this pull request May 3, 2024
Merged
engine-flutter-autoroll added a commit to engine-flutter-autoroll/packages that referenced this pull request May 3, 2024
@engine-flutter-autoroll
7436cc25e Add default arguments to AnimatedPhysicalModel (flutter/f…
7d3a5ae 
…lutter#147424)
auto-submit bot pushed a commit to flutter/packages that referenced this pull request May 3, 2024
@engine-flutter-autoroll
Roll Flutter from bf7191fd3884 to f1037a01b796 (21 revisions) (#6641)
4efbbb5 
flutter/flutter@bf7191f...f1037a0

2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 445c3bfc0d5b to 8cce00433073 (1 revision) (flutter/flutter#147778)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f9edbeeceb3 to 445c3bfc0d5b (1 revision) (flutter/flutter#147776)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75eb18090510 to 1f9edbeeceb3 (1 revision) (flutter/flutter#147769)
2024-05-03 108989782+drown0315@users.noreply.github.com Improved documentation for SpringSimulation (flutter/flutter#146674)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8d81a4f6e5a to 75eb18090510 (1 revision) (flutter/flutter#147766)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8c8cf4384f0 to b8d81a4f6e5a (2 revisions) (flutter/flutter#147765)
2024-05-03 gspencergoog@users.noreply.github.com Move snippets package back into flutter repo (flutter/flutter#147690)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98a800b00cfc to d8c8cf4384f0 (2 revisions) (flutter/flutter#147763)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from c380e9fd4122 to 98a800b00cfc (3 revisions) (flutter/flutter#147761)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc71b650a70a to c380e9fd4122 (4 revisions) (flutter/flutter#147759)
2024-05-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147741)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f1f81915620 to fc71b650a70a (2 revisions) (flutter/flutter#147753)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5088f63ecee2 to 3f1f81915620 (3 revisions) (flutter/flutter#147748)
2024-05-02 yjbanov@google.com [web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (flutter/flutter#147736)
2024-05-02 nate.w5687@gmail.com Control flow collections: `flutter_tools/` (flutter/flutter#147450)
2024-05-02 nate.w5687@gmail.com Add default arguments to `AnimatedPhysicalModel` (flutter/flutter#147424)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9982b5ffd913 to 5088f63ecee2 (3 revisions) (flutter/flutter#147740)
2024-05-02 31859944+LongCatIsLooong@users.noreply.github.com `_RenderDecorator.computeDryBaseline`  (flutter/flutter#146365)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1126e59b698 to 9982b5ffd913 (1 revision) (flutter/flutter#147727)
2024-05-02 yjbanov@google.com [web] increase chromedriver logging level (flutter/flutter#147687)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1fb36ac9d718 to e1126e59b698 (1 revision) (flutter/flutter#147720)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
vashworth pushed a commit to vashworth/packages that referenced this pull request May 6, 2024
@engine-flutter-autoroll @vashworth
Roll Flutter from bf7191fd3884 to f1037a01b796 (21 revisions) (flutte…
094440d 
…r#6641)

flutter/flutter@bf7191f...f1037a0

2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 445c3bfc0d5b to 8cce00433073 (1 revision) (flutter/flutter#147778)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1f9edbeeceb3 to 445c3bfc0d5b (1 revision) (flutter/flutter#147776)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 75eb18090510 to 1f9edbeeceb3 (1 revision) (flutter/flutter#147769)
2024-05-03 108989782+drown0315@users.noreply.github.com Improved documentation for SpringSimulation (flutter/flutter#146674)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from b8d81a4f6e5a to 75eb18090510 (1 revision) (flutter/flutter#147766)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from d8c8cf4384f0 to b8d81a4f6e5a (2 revisions) (flutter/flutter#147765)
2024-05-03 gspencergoog@users.noreply.github.com Move snippets package back into flutter repo (flutter/flutter#147690)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 98a800b00cfc to d8c8cf4384f0 (2 revisions) (flutter/flutter#147763)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from c380e9fd4122 to 98a800b00cfc (3 revisions) (flutter/flutter#147761)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from fc71b650a70a to c380e9fd4122 (4 revisions) (flutter/flutter#147759)
2024-05-03 137456488+flutter-pub-roller-bot@users.noreply.github.com Roll pub packages (flutter/flutter#147741)
2024-05-03 engine-flutter-autoroll@skia.org Roll Flutter Engine from 3f1f81915620 to fc71b650a70a (2 revisions) (flutter/flutter#147753)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 5088f63ecee2 to 3f1f81915620 (3 revisions) (flutter/flutter#147748)
2024-05-02 yjbanov@google.com [web] skip debug mode CanvasKit e2e tests due to flakiness; unskip all other modes (flutter/flutter#147736)
2024-05-02 nate.w5687@gmail.com Control flow collections: `flutter_tools/` (flutter/flutter#147450)
2024-05-02 nate.w5687@gmail.com Add default arguments to `AnimatedPhysicalModel` (flutter/flutter#147424)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 9982b5ffd913 to 5088f63ecee2 (3 revisions) (flutter/flutter#147740)
2024-05-02 31859944+LongCatIsLooong@users.noreply.github.com `_RenderDecorator.computeDryBaseline`  (flutter/flutter#146365)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from e1126e59b698 to 9982b5ffd913 (1 revision) (flutter/flutter#147727)
2024-05-02 yjbanov@google.com [web] increase chromedriver logging level (flutter/flutter#147687)
2024-05-02 engine-flutter-autoroll@skia.org Roll Flutter Engine from 1fb36ac9d718 to e1126e59b698 (1 revision) (flutter/flutter#147720)

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/flutter-packages
Please CC dit@google.com,rmistry@google.com,stuartmorgan@google.com on the revert to ensure that a human
is aware of the problem.

To file a bug in Packages: https://github.com/flutter/flutter/issues/new/choose

To report a problem with the AutoRoller itself, please file a bug:
https://issues.skia.org/issues/new?component=1389291&template=1850622

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goderbauer goderbauer goderbauer approved these changes

Assignees
No one assigned
Labels
a: animation Animation APIs autosubmit Merge PR when tree becomes green via auto submit App f: material design flutter/packages/flutter/material repository. framework flutter/packages/flutter repository. See also f: labels.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nate-thegrate @Hixie @goderbauer