[Impeller] immediately encode blit commands for Vulkan. #52794
Merged
+352
−635
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonahwilliams
commented
May 14, 2024
| @@ -61,16 +75,81 @@ bool BlitPassVK::OnCopyTextureToTextureCommand( | |||
| IRect source_region, | |||
| IPoint destination_origin, | |||
| std::string label) { | |||
| auto command = std::make_unique<BlitCopyTextureToTextureCommandVK>(); | |||
There was a problem hiding this comment.
heap allocation boo
jonahwilliams
changed the title
chinmaygarde
approved these changes
May 14, 2024
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2024
Metal equivalent of #52794 No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
auto-submit bot
added a commit
that referenced
this pull request
May 14, 2024
…)" (#52816) Reverts: #52795 Initiated by: jonahwilliams Reason for reverting: failing postsubmit testing -[MTLIGAccelCommandBuffer renderCommandEncoderWithDescriptor:]:438: failed assertion `Already have uncommitted encoder' Original PR Author: jonahwilliams Reviewed By: {chinmaygarde} This change reverts the following previous change: Metal equivalent of #52794 No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
jonahwilliams
added
the
autosubmit
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 15, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 15, 2024
…148367) flutter/engine@55c62ff...d35a1a6 2024-05-15 jason-simmons@users.noreply.github.com Roll FreeType from af4c2d86 to bfc3453f (flutter/engine#52829) 2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Vulkan. (flutter/engine#52794) 2024-05-14 34871572+gmackall@users.noreply.github.com Fix non-vd android platform view input event offsets (flutter/engine#52532) 2024-05-14 skia-flutter-autoroll@skia.org Roll Dart SDK from 0380354e2448 to 0b77fbab8cf5 (1 revision) (flutter/engine#52827) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No reason to defer encoding. Just like cmd buffers, we can immediately encode this. Reduce heap allocation of command objects, which were additionally stored in unique ptrs for extra memory inefficiency.