[Impeller] immediately encode blit commands for Metal. #52795
Merged
+157
−300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this pull request may not have tests. Please make sure to add tests before merging. If you need an exemption to this rule, contact "@test-exemption-reviewer" in the #hackers channel in Chat (don't just cc them here, they won't see it! Use Discord!). If you are not sure if you need tests, consider this rule of thumb: the purpose of a test is to make sure someone doesn't accidentally revert the fix. Ask yourself, is there anything in your PR that you feel it is important we not accidentally revert back to how it was before your fix? Reviewers: Read the Tree Hygiene page and make sure this patch meets those guidelines before LGTMing. |
chinmaygarde
approved these changes
May 14, 2024
jonahwilliams
added
the
autosubmit
|
reason for revert: failing postsubmit testing -[MTLIGAccelCommandBuffer renderCommandEncoderWithDescriptor:]:438: failed assertion `Already have uncommitted encoder' |
jonahwilliams
added
the
revert
auto-submit bot
pushed a commit
that referenced
this pull request
May 14, 2024
This reverts commit 46ebd52.
auto-submit
bot
removed
the
revert
auto-submit bot
added a commit
that referenced
this pull request
May 14, 2024
…)" (#52816) Reverts: #52795 Initiated by: jonahwilliams Reason for reverting: failing postsubmit testing -[MTLIGAccelCommandBuffer renderCommandEncoderWithDescriptor:]:438: failed assertion `Already have uncommitted encoder' Original PR Author: jonahwilliams Reviewed By: {chinmaygarde} This change reverts the following previous change: Metal equivalent of #52794 No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.
engine-flutter-autoroll
added a commit
to engine-flutter-autoroll/flutter
that referenced
this pull request
May 14, 2024
auto-submit bot
pushed a commit
to flutter/flutter
that referenced
this pull request
May 14, 2024
…148351) flutter/engine@ae9ff69...1b508a0 2024-05-14 98614782+auto-submit[bot]@users.noreply.github.com Reverts "[Impeller] immediately encode blit commands for Metal. (#52795)" (flutter/engine#52816) 2024-05-14 jonahwilliams@google.com [Impeller] immediately encode blit commands for Metal. (flutter/engine#52795) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/flutter-engine-flutter-autoroll Please CC bdero@google.com,rmistry@google.com,zra@google.com on the revert to ensure that a human is aware of the problem. To file a bug in Flutter: https://github.com/flutter/flutter/issues/new/choose To report a problem with the AutoRoller itself, please file a bug: https://issues.skia.org/issues/new?component=1389291&template=1850622 Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/main/autoroll/README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Metal equivalent of #52794
No need to defer encoding of blit commands when the command encoder already defers execution until we submit the command buffer. Removes extra indirection and heap allocation.