New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split ObjectAssertionSpecs in multiple files #2416
Split ObjectAssertionSpecs in multiple files #2416
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.2.8
with:
upload-result: true Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 6683878417
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For reference: this work started with the discussion in #1551.
We didn't create any guidelines back then on when we considered a test class of nested classes eligible to be split into separate files.
Some shell scripts I made while looking into this:
Longest file lengths:
find . -name "*.cs" -exec wc -l {} + | head -n -1 | sort -n | grep -vEi '\.[a-z]+\.cs'
Most nested classes:
grep -rEc --include=*.cs '^ public class' | grep -vEi '(\.[a-z]+\.cs|:[01]$)' | sort -t':' -k 2 -n
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Split the huge
ObjectAssertionSpecs
file into multiple partial classes, similar to the change in #1903 forStringAssertionSpecs
.IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome