New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split NumericAssertionSpecs in multiple files #2423
Split NumericAssertionSpecs in multiple files #2423
Conversation
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked View the detailed Qodana reportTo be able to view the detailed Qodana report, you can either:
To get - name: 'Qodana Scan'
uses: JetBrains/qodana-action@v2023.2.8
with:
upload-result: true Contact Qodana teamContact us at qodana-support@jetbrains.com
|
😭 |
I have no idea, why this build fails and all other succeed 😢 |
This seems to happen when the target branch of this PR gets new commits (e.g. when another PR is merged). |
0779a9f
to
581962f
Compare
Pull Request Test Coverage Report for Build 6721483909
💛 - Coveralls |
After a rebase it seems to work now... |
Split the huge
NumericAssertionSpecs
file (4008 LoC) into multiple partial classes, similar to the change in #2416 forObjectAssertionSpecs
.IMPORTANT
./build.sh --target spellcheck
or.\build.ps1 --target spellcheck
before pushing and check the good outcome