Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split NumericAssertionSpecs in multiple files #2423

Merged

Conversation

vbreuss
Copy link
Contributor

@vbreuss vbreuss commented Nov 1, 2023

Split the huge NumericAssertionSpecs file (4008 LoC) into multiple partial classes, similar to the change in #2416 for ObjectAssertionSpecs.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

Copy link

github-actions bot commented Nov 1, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup
Copy link
Member

jnyrup commented Nov 1, 2023

Couldn't find any remote tips from remote 'https://github.com/fluentassertions/fluentassertions' pointing at the commit '15e2eb9725c759a0f863f4590c89ffb9b73f4cf5'.

😭

@vbreuss
Copy link
Contributor Author

vbreuss commented Nov 1, 2023

I have no idea, why this build fails and all other succeed 😢
Anything I can do?

@dennisdoomen
Copy link
Member

I have no idea, why this build fails and all other succeed 😢

This seems to happen when the target branch of this PR gets new commits (e.g. when another PR is merged).

@vbreuss vbreuss force-pushed the topic/split-numericassertionspecs branch from 0779a9f to 581962f Compare November 1, 2023 15:13
@coveralls
Copy link

Pull Request Test Coverage Report for Build 6721483909

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.389%

Totals Coverage Status
Change from base Build 6721417298: 0.0%
Covered Lines: 11714
Relevant Lines: 11905

💛 - Coveralls

@vbreuss
Copy link
Contributor Author

vbreuss commented Nov 1, 2023

This seems to happen when the target branch of this PR gets new commits (e.g. when another PR is merged).

After a rebase it seems to work now...

@jnyrup jnyrup merged commit 251c9ec into fluentassertions:develop Nov 2, 2023
5 checks passed
@vbreuss vbreuss deleted the topic/split-numericassertionspecs branch November 14, 2023 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants