[react-native-vision-camera] Add definition #4533
Conversation
joshuanapoli
commented
Oct 12, 2023
joshuanapoli
commented
- Links to documentation: https://react-native-vision-camera.com/
- Link to GitHub or NPM: https://github.com/mrousavy/react-native-vision-camera
- Type of contribution: new definition
| @@ -0,0 +1,1358 @@ | |||
| declare module "react-native-vision-camera" { | |||
| // import type { ViewProps } from "react-native"; | |||
There was a problem hiding this comment.
React native is flow-typed but not available in the test environment.. We should probably aim to add this into the harness so that react-native packages can resolve properly
There was a problem hiding this comment.
Yeah; importing from react-native would be nice. I think that the react-native dependency would still be impossible in flow-typed v4, since react-native types aren't supplied through this project.
There was a problem hiding this comment.
I'll raise an issue to track, I think I can do something with the CLI later so that we can test with react-native as a dependency
There was a problem hiding this comment.
@joshuanapoli I need some help. How does react-native ship flow definitions? As I was creating the change i realised that there are no .js.flow files as far as I can tell in the react-native package
There was a problem hiding this comment.
@Brianzchen The source files in the shipped package are all flow-typed. As far as I understand, the package.json refers to these flow-typed files. As configured by package.json, the flow-typed files will be loaded at "run time" by import/requre. There are no pure JavaScript files in the package. Also, configured by package.json, Typescript .d.ts files are loaded from the types directory.
Each of the main sources have a flow comment:
/**
[...]
* @format
* @flow strict-local
*/
Evidently, the metro bundler strips the flow types.
I hope that this information is correct. It seems surprising to me.
| | CaptureError | ||
| | SystemError | ||
| | UnknownError; | ||
| declare class CameraError<TCode: CameraErrorCode> mixins Error { |
There was a problem hiding this comment.
is it possible to not use mixins here?
There was a problem hiding this comment.
Thanks; the "mixins" are replaced with "extends" in c277db7
| */ | ||
| frameProcessorFps?: number | "auto", | ||
| ... | ||
| } & ViewProps; |
There was a problem hiding this comment.
generally prefer this as it's usually what people intend when they port from TS definitions
{
...ViewProps,
// other stuff
}
There was a problem hiding this comment.
Thanks. Fixed in cff3d5b
|
#4535 |
