Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cli] Fix running definition tests locally on MacOS #4440

Merged
merged 2 commits into from May 14, 2023

Conversation

Brianzchen
Copy link
Member

If you look at the list of releases, previously up to version v0.200.1 flow used to release only a x86 binary

Screen Shot 2023-05-14 at 9 19 44 am

After this, from v0.201.0 onward flow started releasing osx arm binaries.

Screen Shot 2023-05-14 at 9 20 41 am

The original flow-typed fetching binary logic never anticipated arm, so the logic was never handled and when it found 2 binaries for macos it crashed silently.

What was fixed

  • More logic to binary selection
  • Refined regex expression so that it will never find multiple binaries

Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@Brianzchen Brianzchen merged commit 250e0cb into flow-typed:master May 14, 2023
4 checks passed
@Brianzchen Brianzchen deleted the fix-macos-tests branch May 14, 2023 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants