Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[@testing-library/react] Add v14 #4439

Merged
merged 6 commits into from May 14, 2023
Merged

[@testing-library/react] Add v14 #4439

merged 6 commits into from May 14, 2023

Conversation

Brianzchen
Copy link
Member

Copied from v13, definition is just dropping node versions

Other notes:

@Brianzchen
Copy link
Member Author

Brianzchen commented May 13, 2023 •
edited

There's one change that removed some arg options from some function. Will update that before merging

As mentioned here https://github.com/testing-library/dom-testing-library/releases/tag/v9.0.0

@Brianzchen
Copy link
Member Author

Waiting for #4440 so I can see test failures locally

@gantoine gantoine self-assigned this May 14, 2023
gantoine
gantoine approved these changes May 14, 2023
View reviewed changes
Copy link
Member

@gantoine gantoine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Structure looks good, you can merge it once the other PR is merge.

@Brianzchen Brianzchen merged commit 9af16a6 into flow-typed:master May 14, 2023
4 checks passed
@Brianzchen Brianzchen deleted the rtl-14 branch May 14, 2023 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gantoine gantoine gantoine approved these changes

Assignees

@gantoine gantoine

Labels
work in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Brianzchen @gantoine