Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix runTests command for flow@^0.200.0 set exact_by_default option #4423

Merged

Conversation

iamdey
Copy link
Contributor

@iamdey iamdey commented Mar 15, 2023

from 0.200.0, exact_by_default option is required in flowconfig and from 0.202.0, this option is set to true by default

cf. https://flow.org/en/docs/config/options/#toc-exact-by-default-boolean

  • Type of contribution: fix

Fixes #4422

from 0.200.0, `exact_by_default` option is required in flowconfig
and from 0.202.0, this option is `true` by default

cf. https://flow.org/en/docs/config/options/#toc-exact-by-default-boolean
Copy link
Member

@pascalduez pascalduez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's hope we did a good job at enforcing object notations. But anyway, let's move forward.

Thanks!

@gantoine gantoine merged commit d934b43 into flow-typed:master Mar 15, 2023
@iamdey iamdey deleted the update_flowconfig_for_tests_from0200 branch March 15, 2023 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to run tests on definitions
3 participants