Skip to content

Commit

Permalink
Fix runTests command for flow@^0.200.0 set exact_by_default option (#…
Browse files Browse the repository at this point in the history
…4423)

from 0.200.0, `exact_by_default` option is required in flowconfig
and from 0.202.0, this option is `true` by default

cf. https://flow.org/en/docs/config/options/#toc-exact-by-default-boolean
  • Loading branch information
iamdey committed Mar 15, 2023
1 parent d2cf939 commit d934b43
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions cli/src/commands/runTests.js
Expand Up @@ -319,6 +319,7 @@ async function writeFlowConfig(repoDirPath, testDirPath, libDefPath, version) {
'[options]',
'include_warnings=true',
'server.max_workers=0',
semver.gte(version, '0.200.0') ? 'exact_by_default=true' : '', // from version 0.202.0 default is true
// Fixes out of shared memory error for Mac Rosetta 2, see https://github.com/facebook/flow/issues/8538
'sharedmemory.heap_size=3221225472',
semver.lt(version, '0.125.0')
Expand Down Expand Up @@ -478,6 +479,7 @@ async function removeTrashFromBinDir() {
const CONFIGURATION_CHANGE_VERSIONS = [
'v0.104.0', // Adding lint
'v0.125.0', // Remove suppress_comments
'v0.200.0', // exact_by_default become required
];

// This function splits a list of flow versions into a list of lists of versions
Expand Down

0 comments on commit d934b43

Please sign in to comment.