Add an optional create additions callback #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If specified json will pass the string json_class and use the value returned as the ruby class to instantiate
|
Hey just updated the patches to work on travis. Wasn't anything major, just had the wrong types for create_additions in the extensions. The builds that are failing are the allowed failures for rubinius as well as the latest ruby head (which looks to be a ruby issue as it's not even getting to installing the deps nevermind testing json itself). I'm assuming travis integration is acceptable at this point. If there is anything else that needs TBD just shout out, would love to see this make it in so I don't have to implement one of the workarounds in rjr. Thanks. |
marcandre
suggested changes
Jun 25, 2020
| a = A.new(666) | ||
| assert A.json_creatable? | ||
| json = generate(a) | ||
| a_again = JSON.parse(json, :create_additions => proc { |e| A2 }) |
There was a problem hiding this comment.
A test is missing on what is e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to workarounds describe in issue #179.
If not set create_additions still implements current behaviour.
If set to a proc this will be invoked in lieu of deep const get to evaluate the json class string and return a ruby class. It is up to the developer to specify the implementation details of this mapping.
Putting this out there for comments and hopeful merger into the codebase.