Poor handle_message performance

[ssimeonov]

handle_message is implemented such that the same JSON-encoded data would be parsed a minimum of 2 and a maximum of 4 times. Is there a particular reason for this choice?

[movitto]

None other than it was quickest thing todo :-)

It might get parsed more times than that as two levels of parsing occur to determine message type (lib/rjr/node.rb#L186) and extract message contents in node.rb (lib/rjr/node.rb#L205) and each call to JSONParser results in two parser calls (lib/rjr/util/json_parser.rb#L89, see this for why this occurs: flori/json#182).

Agree that this should be optimized, on the TODO list, just haven't had cycles to do it. Would gladly accept any pr's you (or anyone else) wanted to submit

[movitto]

@ssimeonov fixed with commit 2bacb30

Now json message is parsed only once and then analyzed from there.

[ssimeonov]

Great, Mo, this is a nice improvement.