fix: throw an error when server.ts calls run function

CHANGELOG.md

@@ -0,0 +1 @@
+- (Angular 17+) throw an error when server.ts calls `run` function (#6651)

src/frameworks/angular/utils.ts

@@ -11,7 +11,46 @@
 import { assertIsString } from "../../utils";
 import { coerce } from "semver";
 
+/**
+ * @param serverFilePath path to server.ts
+ * @return true when `run` function is called in server.ts, it breaks SSR (Angular 17+) on Firebase.
+ */
+const isRunImplementedAndCalledInServer = async (serverFilePath: string): Promise<boolean> => {
+  // Dynamically import the TypeScript compiler module
+  const ts = await import("typescript");
+  const sourceCode = ts.sys.readFile(serverFilePath);
+  const functionName = "run";
+
+  if (!sourceCode) {
+    return false;
+  }
+
+  const sourceFile = ts.createSourceFile("server.ts", sourceCode, ts.ScriptTarget.Latest, true);
+
+  let isRunDefined = false;
+  let isRunCalled = false;
+
+  // Recursive function to traverse the AST
+  const traverse = (node: any): void => {
+    if (ts.isFunctionDeclaration(node) && node.name && node.name.getText() === functionName) {
+      isRunDefined = true;
+    }
+    if (
+      ts.isCallExpression(node) &&
+      ts.isIdentifier(node.expression) &&
+      node.expression.getText() === functionName
+    ) {
+      isRunCalled = true;
+    }
+    ts.forEachChild(node, traverse);
+  };
+
+  traverse(sourceFile);
+
+  return isRunDefined && isRunCalled;
+};
+
 async function localesForTarget(
   dir: string,
   architectHost: WorkspaceNodeModulesArchitectHost,
   target: Target,
@@ -27,7 +66,7 @@
   let locales: string[] | undefined = undefined;
   let defaultLocale: string | undefined = undefined;
   if (targetOptions.localize) {
     const i18n: AngularI18nConfig | undefined = workspaceProject.extensions?.i18n as any;
     if (!i18n) throw new FirebaseError(`No i18n config on project.`);
     if (typeof i18n.sourceLocale === "string") {
       throw new FirebaseError(`All your i18n locales must have a baseHref of "" on Firebase, use an object for sourceLocale in your angular.json:
@@ -49,7 +88,7 @@
       for (const [locale, { baseHref }] of Object.entries(i18n.locales)) {
         if (baseHref !== "")
           throw new FirebaseError(
             `All your i18n locales must have a baseHref of \"\" on Firebase, errored on ${locale}.`,
           );
         locales.push(locale);
       }
@@ -96,7 +135,7 @@
   ];
 }
 
 export async function getAllTargets(purpose: BUILD_TARGET_PURPOSE, dir: string) {
   const validBuilders = getValidBuilders(purpose);
   const [{ NodeJsAsyncHost }, { workspaces }, { targetStringFromTarget }] = await Promise.all([
     relativeRequire(dir, "@angular-devkit/core/node"),
@@ -482,6 +521,16 @@
     );
   }
   const serverEntry = buildTarget ? "server.mjs" : serverTarget && "main.js";
+
+  if (
+    serverEntry === "server.mjs" &&
+    (await isRunImplementedAndCalledInServer(join(sourceDir, "server.ts")))
+  ) {
+    throw new FirebaseError(
+      "For SSR to work properly, please remove the `run` function call from the `server.ts` file.",
+    );
+  }
+
   const externalDependencies: string[] = (serverTargetOptions.externalDependencies as any) || [];
   const bundleDependencies = serverTargetOptions.bundleDependencies ?? true;
   const { locales: browserLocales } = await localesForTarget(