fix: throw an error when server.ts calls run function #6977
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There was a following change in main server file template in Angular 17:
to
The guard to call
run
function was removed. In the result there is an issue when someone tries to deploy Angular 17+ app with SSR.I've added a check in the deployment script, if
run
function is called inserver.ts
then error with message:For SSR to work properly, please remove the
runfunction call from the
server.tsfile.
will be thrown.The solution will provide better guidance to resolve this issue: #6651.
Scenarios Tested
Angular 17+:
run
call inserver.ts
- deployment was successfulrun
call inserver.ts
- deployment was successfulserver.ts
has gotrun
call and SSR is enabled inangular.json
- an error with guidance was thrownserver.ts
has gotrun
call and SSR is disabled inangular.json
- deployment was successfulSample Commands