Upgrade individual packages to TS 4.7.4 #6799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 70cf8a7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 45 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1This report is too large (144,373 characters) to be displayed here in a GitHub comment. Please use the below link to see the full report on Google Cloud Storage.Test Logs |
hsubox76
force-pushed
the
ch-tsupgrade-1
branch
from
b3b8bc3
to
aa0a71f
Compare
hsubox76
requested review from
egilmorez,
erikeldridge,
jposuna,
avolkovi,
yoyomyo,
lisajian,
sam-gc,
yuchenshi,
zwu52,
maneesht,
tonyjhuang,
jsdt,
jmwski and
dwyfrequency
as code owners
lahirumaramba
approved these changes
Nov 21, 2022
| @@ -24,6 +24,6 @@ | |||
| "@firebase/remote-config-compat": "0.1.16" | |||
| }, | |||
| "devDependencies": { | |||
| "typescript": "4.2.2" | |||
| "typescript": "4.7.4" | |||
| } | |||
| } | |||
There was a problem hiding this comment.
nit: should we fix these new lines?
There was a problem hiding this comment.
Sure, while we're in this file. Fixed.
| @@ -44,12 +44,12 @@ const enum EffectiveConnectionType { | |||
| * | |||
| * ref: https://developer.mozilla.org/en-US/docs/Web/API/NetworkInformation | |||
| */ | |||
| interface NetworkInformation { | |||
| interface NetworkInformationWithEffectiveType extends NetworkInformation { | |||
There was a problem hiding this comment.
Just curious: what made these types to rename to NetworkInformationWithEffectiveType? Could this be breaking?
There was a problem hiding this comment.
I don't think so, it's not publicly exposed and is only used here. I will add a comment about what the deal is:
// `effectiveType` is an experimental property and not included in
// TypeScript's typings for the native NetworkInformation interface
hsubox76
force-pushed
the
ch-tsupgrade-1
branch
from
5018b60
to
70cf8a7
Compare
Merged
levino
pushed a commit
to levino/firebase-js-sdk
that referenced
this pull request
Dec 10, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously only the main package.json had its typescript version bumped.