Upgrade individual packages to TS 4.7.4 (firebase#6799)

levino · Dec 10, 2022 · 24a8cf2 · 24a8cf2
1 parent 14b86c2
commit 24a8cf2
Show file tree

Hide file tree

Showing 77 changed files with 274 additions and 150 deletions.
diff --git a/.changeset/tidy-games-fry.md b/.changeset/tidy-games-fry.md
@@ -0,0 +1,47 @@
+---
+'@firebase/analytics': minor
+'@firebase/analytics-compat': minor
+'@firebase/analytics-interop-types': minor
+'@firebase/analytics-types': minor
+'@firebase/app': minor
+'@firebase/app-check': minor
+'@firebase/app-check-compat': minor
+'@firebase/app-check-interop-types': minor
+'@firebase/app-check-types': minor
+'@firebase/app-compat': minor
+'@firebase/app-types': minor
+'@firebase/auth': minor
+'@firebase/auth-compat': minor
+'@firebase/auth-interop-types': minor
+'@firebase/auth-types': minor
+'@firebase/component': minor
+'@firebase/database': minor
+'@firebase/database-compat': minor
+'@firebase/database-types': minor
+'@firebase/functions': minor
+'@firebase/functions-compat': minor
+'@firebase/functions-types': minor
+'@firebase/installations': minor
+'@firebase/installations-compat': minor
+'@firebase/installations-types': minor
+'@firebase/logger': minor
+'@firebase/messaging': minor
+'@firebase/messaging-compat': minor
+'@firebase/messaging-interop-types': minor
+'@firebase/performance': minor
+'@firebase/performance-compat': minor
+'@firebase/performance-types': minor
+'@firebase/remote-config': minor
+'@firebase/remote-config-compat': minor
+'@firebase/remote-config-types': minor
+'@firebase/storage': minor
+'@firebase/storage-compat': minor
+'@firebase/storage-types': minor
+'@firebase/template': minor
+'@firebase/template-types': minor
+'@firebase/util': minor
+'@firebase/webchannel-wrapper': minor
+'firebase': minor
+---
+
+Update TypeScript version to 4.7.4.
diff --git a/integration/compat-interop/package.json b/integration/compat-interop/package.json
@@ -24,6 +24,6 @@
     "@firebase/remote-config-compat": "0.1.16"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
-}
+}
diff --git a/integration/compat-typings/package.json b/integration/compat-typings/package.json
@@ -10,6 +10,6 @@
     "firebase": "*"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/integration/firebase/package.json b/integration/firebase/package.json
@@ -20,6 +20,6 @@
     "karma-typescript": "5.5.3",
     "mocha": "9.2.2",
     "npm-run-all": "4.1.5",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/package.json b/package.json
@@ -86,9 +86,9 @@
     "@types/sinon-chai": "3.2.8",
     "@types/tmp": "0.2.3",
     "@types/yargs": "17.0.13",
-    "@typescript-eslint/eslint-plugin": "4.33.0",
-    "@typescript-eslint/eslint-plugin-tslint": "4.33.0",
-    "@typescript-eslint/parser": "4.33.0",
+    "@typescript-eslint/eslint-plugin": "5.43.0",
+    "@typescript-eslint/eslint-plugin-tslint": "5.43.0",
+    "@typescript-eslint/parser": "5.43.0",
     "api-documenter-me": "0.1.1",
     "api-extractor-me": "0.1.2",
     "babel-loader": "8.2.5",

diff --git a/packages/analytics-compat/package.json b/packages/analytics-compat/package.json
@@ -28,7 +28,7 @@
     "rollup": "2.79.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/analytics-compat",

diff --git a/packages/analytics-interop-types/package.json b/packages/analytics-interop-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/analytics-types/package.json b/packages/analytics-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/analytics/package.json b/packages/analytics/package.json
@@ -54,7 +54,7 @@
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "13.3.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/analytics",

diff --git a/packages/analytics/src/get-config.test.ts b/packages/analytics/src/get-config.test.ts
@@ -16,7 +16,7 @@
  */
 
 import { expect } from 'chai';
-import { SinonStub, stub, useFakeTimers, restore } from 'sinon';
+import { SinonStub, stub, useFakeTimers, restore, match } from 'sinon';
 import '../testing/setup';
 import {
   fetchDynamicConfig,
@@ -246,7 +246,7 @@ describe('Dynamic Config Fetch Functions', () => {
         });
         // Set fetch timeout to 50 ms.
         await fetchDynamicConfigWithRetry(app, fakeRetryData, 50);
-        expect(consoleStub.args[0][1]).to.include(fakeMeasurementId);
+        expect(consoleStub).calledWith(match.any, match(fakeMeasurementId));
         consoleStub.restore();
       }
     );

diff --git a/packages/app-check-compat/package.json b/packages/app-check-compat/package.json
@@ -50,7 +50,7 @@
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "13.3.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/app-check",

diff --git a/packages/app-check-interop-types/package.json b/packages/app-check-interop-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/app-check-types/package.json b/packages/app-check-types/package.json
@@ -20,6 +20,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/app-check/package.json b/packages/app-check/package.json
@@ -51,7 +51,7 @@
     "@rollup/plugin-json": "4.1.0",
     "@rollup/plugin-node-resolve": "13.3.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/app-check",

diff --git a/packages/app-check/src/client.test.ts b/packages/app-check/src/client.test.ts
@@ -31,7 +31,10 @@ import { BASE_ENDPOINT } from './constants';
 
 describe('client', () => {
   let app: FirebaseApp;
-  let fetchStub: SinonStub<[RequestInfo, RequestInit?], Promise<Response>>;
+  let fetchStub: SinonStub<
+    [RequestInfo | URL, RequestInit?],
+    Promise<Response>
+  >;
   beforeEach(() => {
     app = getFakeApp();
     fetchStub = stub(window, 'fetch').returns(

diff --git a/packages/app-compat/package.json b/packages/app-compat/package.json
@@ -51,7 +51,7 @@
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/app-compat",

diff --git a/packages/app-types/package.json b/packages/app-types/package.json
@@ -24,6 +24,6 @@
     "@firebase/logger": "0.2.6"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/app/package.json b/packages/app/package.json
@@ -50,7 +50,7 @@
     "rollup": "2.79.1",
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/app",

diff --git a/packages/auth-compat/demo/package.json b/packages/auth-compat/demo/package.json
@@ -34,7 +34,7 @@
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
     "rollup-plugin-uglify": "6.0.4",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/auth-compat/demo",

diff --git a/packages/auth-compat/package.json b/packages/auth-compat/package.json
@@ -61,7 +61,7 @@
     "rollup-plugin-replace": "2.2.0",
     "rollup-plugin-typescript2": "0.31.2",
     "selenium-webdriver": "4.5.0",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/auth-compat",

diff --git a/packages/auth-interop-types/package.json b/packages/auth-interop-types/package.json
@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/auth-types/package.json b/packages/auth-types/package.json
@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/auth/package.json b/packages/auth/package.json
@@ -118,7 +118,7 @@
     "rollup-plugin-sourcemaps": "0.6.3",
     "rollup-plugin-typescript2": "0.31.2",
     "selenium-webdriver": "4.5.0",
-    "typescript": "4.2.2",
+    "typescript": "4.7.4",
     "@types/express": "4.17.14"
   },
   "repository": {

diff --git a/packages/auth/src/api/index.test.ts b/packages/auth/src/api/index.test.ts
@@ -383,7 +383,9 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.NEED_CONFIRMATION}`);
+        expect((e as FirebaseError).code).to.eq(
+          `auth/${AuthErrorCode.NEED_CONFIRMATION}`
+        );
         expect((e as FirebaseError).customData!._tokenResponse).to.eql({
           needConfirmation: true,
           idToken: 'id-token'
@@ -413,7 +415,9 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.CREDENTIAL_ALREADY_IN_USE}`);
+        expect((e as FirebaseError).code).to.eq(
+          `auth/${AuthErrorCode.CREDENTIAL_ALREADY_IN_USE}`
+        );
         expect((e as FirebaseError).customData!._tokenResponse).to.eql(
           response
         );
@@ -444,7 +448,9 @@ describe('api/_performApiRequest', () => {
         );
         assert.fail('Call should have failed');
       } catch (e) {
-        expect(e.code).to.eq(`auth/${AuthErrorCode.EMAIL_EXISTS}`);
+        expect((e as FirebaseError).code).to.eq(
+          `auth/${AuthErrorCode.EMAIL_EXISTS}`
+        );
         expect((e as FirebaseError).customData!.email).to.eq('email@test.com');
         expect((e as FirebaseError).customData!.phoneNumber).to.eq(
           '+1555-this-is-a-number'

diff --git a/packages/auth/src/core/strategies/abstract_popup_redirect_operation.ts b/packages/auth/src/core/strategies/abstract_popup_redirect_operation.ts
@@ -76,7 +76,7 @@ export abstract class AbstractPopupRedirectOperation
           await this.onExecution();
           this.eventManager.registerConsumer(this);
         } catch (e) {
-          this.reject(e);
+          this.reject(e as Error);
         }
       }
     );
@@ -102,7 +102,7 @@ export abstract class AbstractPopupRedirectOperation
     try {
       this.resolve(await this.getIdpTask(type)(params));
     } catch (e) {
-      this.reject(e);
+      this.reject(e as Error);
     }
   }
 

diff --git a/packages/auth/src/platform_browser/popup_redirect.test.ts b/packages/auth/src/platform_browser/popup_redirect.test.ts
@@ -93,7 +93,7 @@ describe('platform_browser/popup_redirect', () => {
   });
 
   context('#_openPopup', () => {
-    let popupUrl: string | undefined;
+    let popupUrl: string | URL | undefined;
     let provider: OAuthProvider;
     const event = AuthEventType.LINK_VIA_POPUP;
 

diff --git a/packages/auth/test/helpers/mock_fetch.ts b/packages/auth/test/helpers/mock_fetch.ts
@@ -34,7 +34,10 @@ let fetchImpl: typeof fetch | null;
 const routes = new Map<string, Route>();
 
 // Using a constant rather than a function to enforce the type matches fetch()
-const fakeFetch: typeof fetch = (input: RequestInfo, request?: RequestInit) => {
+const fakeFetch: typeof fetch = (
+  input: RequestInfo | URL,
+  request?: RequestInit
+) => {
   if (typeof input !== 'string') {
     throw new Error('URL passed to fetch was not a string');
   }

diff --git a/packages/component/package.json b/packages/component/package.json
@@ -39,7 +39,7 @@
   "devDependencies": {
     "rollup": "2.79.1",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/component",

diff --git a/packages/database-compat/package.json b/packages/database-compat/package.json
@@ -53,7 +53,8 @@
     "tslib": "^2.1.0"
   },
   "devDependencies": {
-    "@firebase/app-compat": "0.1.39"
+    "@firebase/app-compat": "0.1.39",
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/database-compat",

diff --git a/packages/database-types/package.json b/packages/database-types/package.json
@@ -24,6 +24,6 @@
     "url": "https://github.com/firebase/firebase-js-sdk/issues"
   },
   "devDependencies": {
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   }
 }
diff --git a/packages/database/package.json b/packages/database/package.json
@@ -56,7 +56,7 @@
     "@firebase/app": "0.8.4",
     "rollup": "2.79.1",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/database",

diff --git a/packages/functions-compat/package.json b/packages/functions-compat/package.json
@@ -31,7 +31,7 @@
     "rollup": "2.79.1",
     "@rollup/plugin-json": "4.1.0",
     "rollup-plugin-typescript2": "0.31.2",
-    "typescript": "4.2.2"
+    "typescript": "4.7.4"
   },
   "repository": {
     "directory": "packages/functions-compat",

diff --git a/packages/functions-compat/src/callable.test.ts b/packages/functions-compat/src/callable.test.ts
@@ -15,7 +15,7 @@
  * limitations under the License.
  */
 import { expect } from 'chai';
-import { FunctionsErrorCode } from '@firebase/functions';
+import { FunctionsError, FunctionsErrorCode } from '@firebase/functions';
 import { createTestService } from '../test/utils';
 import firebase, { FirebaseApp } from '@firebase/app-compat';
 
@@ -35,9 +35,9 @@ async function expectError(
     await promise;
   } catch (e) {
     failed = true;
-    expect(e.code).to.equal(code);
-    expect(e.message).to.equal(message);
-    expect(e.details).to.deep.equal(details);
+    expect((e as FunctionsError).code).to.equal(code);
+    expect((e as FunctionsError).message).to.equal(message);
+    expect((e as FunctionsError).details).to.deep.equal(details);
   }
   if (!failed) {
     expect(false, 'Promise should have failed.').to.be.true;