Warning: Critical dependency: the request of a dependency is an expression

[anisabboud]

Hi, I just updated Firebase SDK to the latest version released yesterday (9.11.0 - 2022-10-06), and now getting a console warning when building the project (with Angular ng build / ng serve):

./node_modules/@firebase/util/dist/index.esm2017.js:741:19-44 - Warning: Critical dependency: the request of a dependency is an expression

Specifically, the warning comes from this line:

which seems to be in this file: firebase-js-sdk/packages/util/src/deferred.ts

firebase-js-sdk/packages/util/src/deferred.ts

Line 39 in 5ad7ff2

this.reject(error);

[google-oss-bot]

I couldn't figure out how to label this issue, so I've labeled it for a human to triage. Hang tight.

[huzaifa3165]

I'm also getting the same warning.

[hsubox76]

This is puzzling because that file hasn't been updated in 2 years. Did you upgrade directly from 9.10.0 to 9.11.0 or did you start from a version earlier than 9.10.0? Did you update any other dependencies as part of that update?

This is the first time @firebase/util has had a version bump since July so it's possible some commit to util between then and now caused it also.

Which products are you using (analytics, app-check, database, firestore, etc.)? It might also be that something changed in the way the product code calls Deferred.

[hsubox76]

Actually I looked up the error and it seems it's a webpack warning about using require() on a dynamic variable. In that case it's most likely caused by this line, which was added recently:

firebase-js-sdk/packages/util/src/defaults.ts

Line 78 in 0a112bd

const json = require(defaultsJsonPath);

and it looks like the source map is a little bit off so it's pointing at a different location in the util bundle. I'll see what I can do to address this.

[nandorojo]

Seeing the same thing on Next.js. Thanks for looking into it @hsubox76.

[tomasconnor]

+1

[Amansg4]

Just had this problem. +1. Don't know a fix though

[nandorojo]

Downgrading to 9.10 fixed it for me.

[hsubox76]

The warning shouldn't affect any code functionality but you can downgrade to 9.10.0 if you want to avoid having a warning (or if I'm wrong and it is affecting your code). I have a fix (#6665) which should be released next week.

[dodomui]

+1

[meenal21]

+1. downgrading to 9.10.0 fixed the issue!

[BasilArackal]

I'm also getting the same warning on a Next.js project

[sdk1990]

+1 on a Next.js project

[abwhb]

+1 on a Next.js project as well

[hsubox76]

As mentioned above, the fix has been merged and will be released this week.

[hsubox76]

The fix has been released in 9.12.0.