New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract uuid function into @firebase/util #6363
Merged
Merged
Changes from 60 commits
Commits
Show all changes
64 commits
Select commit
Hold shift + click to select a range
db50631
WIP
maneesht 46cd378
Simulate add/remove event registration in repoGetValue
jmwski c334171
Fixed duplicate onValue calls
maneesht f7298df
Updated test file
maneesht 00a5907
Updated integration test to include get
maneesht 3ea9604
Reduced timeout for tests
maneesht 9520427
Removed unnecessary imports
maneesht e7dd651
Added back imports
maneesht f7ed576
Removed snapshot param
maneesht 98c6e34
Addressed comments
maneesht 43f1f8a
Fixed test
maneesht 9394170
Removed only
maneesht 2f82052
Removed unnecessary import
maneesht c976987
Updated test
maneesht fc4cf5c
Added extra test
maneesht 7c31ece
Merge branch 'master' into fix-get-cache
maneesht 3959cf3
Fixed formatting
maneesht 536e103
Create rotten-tables-brush.md
maneesht 3812a33
Added documentation
maneesht a8d8ea6
Passed formatting
maneesht 7de3c12
Merge remote-tracking branch 'origin/master' into fix-get-cache
maneesht 766f46d
Addressed comments
maneesht 04356e4
WIP
maneesht a467055
Used unique id instead of foo
maneesht 6145b2b
Used exactCount instead of Count for accumulator
maneesht 788aaa0
Removed only
maneesht 51d57a2
Reformatted
maneesht 41a7303
Removed get wip
maneesht a58bb33
Got minimal repro
maneesht 5d41ce0
Got minimal repro
maneesht bdfd40b
Fixed race condition issue
maneesht 4ca2289
Updated tests
maneesht b52f468
Updated yarn lock file
maneesht 27f9ea1
Updated module type
maneesht 065dab0
Added comment
maneesht d5fef45
Merge remote-tracking branch 'origin/master' into fix-get-cache
maneesht 74fe5e8
Removed unnecessary code
maneesht 5858b86
Merge remote-tracking branch 'origin/master' into fix-get-cache
maneesht be41979
Removed unnecessary comment
maneesht f320a93
Removed unused imports
maneesht c4f8ff7
Updated test to remove redundant assertion
maneesht 1dc798c
Moved query check
maneesht 42e38f6
Updated tests to include example queries
maneesht b4c7f28
Fixed formatting
maneesht 5559921
Added suggestions
maneesht 52fcf72
Fixed formatting
maneesht c553405
Replaced let with const
maneesht a7e5865
Fixed tests
maneesht 98845d1
Fixed test
maneesht 69feeb7
Fixed formatting
maneesht 60f9da0
Fixed tests
maneesht 6f39fef
Removed comments
maneesht 57a8db5
Removed version of uuid
maneesht 31a747e
Added a new line
maneesht bd23960
Addressed comments
maneesht 6656e5a
Extracted out uuid
maneesht 11f31f9
Merge remote-tracking branch 'origin/master' into mtewani/extract-uuidv4
maneesht e1318b6
Reformatted files
maneesht d79919c
Reformatted again
maneesht 5fd68d8
Create tame-rice-peel.md
maneesht 5ee6096
Addressed comments
maneesht 324ce39
Removed global import
maneesht 65234d5
Fixed lint error
maneesht 199478c
Ran formatter
maneesht File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
"@firebase/app-check": patch | ||
"@firebase/app": patch | ||
"@firebase/database": patch | ||
"@firebase/util": patch | ||
--- | ||
|
||
Extract uuid function into @firebase/util |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
/** | ||
* @license | ||
* Copyright 2022 Google LLC | ||
* | ||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||
* you may not use this file except in compliance with the License. | ||
* You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
/** | ||
* Copied from https://stackoverflow.com/a/2117523 | ||
* Generates a new uuid. | ||
maneesht marked this conversation as resolved.
Show resolved
Hide resolved
|
||
*/ | ||
export const uuidv4 = function (): string { | ||
return 'xxxxxxxx-xxxx-4xxx-yxxx-xxxxxxxxxxxx'.replace(/[xy]/g, c => { | ||
const r = (Math.random() * 16) | 0, | ||
v = c === 'x' ? r : (r & 0x3) | 0x8; | ||
return v.toString(16); | ||
}); | ||
}; |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think there are any files from app in this change?