Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract uuid function into @firebase/util #6363

Merged
merged 64 commits into from Jun 16, 2022
Merged

Extract uuid function into @firebase/util #6363

merged 64 commits into from Jun 16, 2022

Commits on May 13, 2022

  1. WIP

    @maneesht
    maneesht committed May 13, 2022
    Copy the full SHA
    db50631 View commit details
    Browse the repository at this point in the history

  2. Simulate add/remove event registration in repoGetValue

    @jmwski
    jmwski committed May 13, 2022
    Copy the full SHA
    46cd378 View commit details
    Browse the repository at this point in the history

Commits on May 17, 2022

  1. Fixed duplicate onValue calls

    @maneesht
    maneesht committed May 17, 2022
    Copy the full SHA
    c334171 View commit details
    Browse the repository at this point in the history

Commits on May 18, 2022

  1. Updated test file

    @maneesht
    maneesht committed May 18, 2022
    Copy the full SHA
    f7298df View commit details
    Browse the repository at this point in the history

Commits on May 19, 2022

  1. Updated integration test to include get

    @maneesht
    maneesht committed May 19, 2022
    Copy the full SHA
    00a5907 View commit details
    Browse the repository at this point in the history

Commits on May 20, 2022

  1. Reduced timeout for tests

    @maneesht
    maneesht committed May 20, 2022
    Copy the full SHA
    3ea9604 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary imports

    @maneesht
    maneesht committed May 20, 2022
    Copy the full SHA
    9520427 View commit details
    Browse the repository at this point in the history

  3. Added back imports

    @maneesht
    maneesht committed May 20, 2022
    Copy the full SHA
    e7dd651 View commit details
    Browse the repository at this point in the history

  4. Removed snapshot param

    @maneesht
    maneesht committed May 20, 2022
    Copy the full SHA
    f7ed576 View commit details
    Browse the repository at this point in the history

Commits on May 23, 2022

  1. Addressed comments

    @maneesht
    maneesht committed May 23, 2022
    Copy the full SHA
    98c6e34 View commit details
    Browse the repository at this point in the history

  2. Fixed test

    @maneesht
    maneesht committed May 23, 2022
    Copy the full SHA
    43f1f8a View commit details
    Browse the repository at this point in the history

  3. Removed only

    @maneesht
    maneesht committed May 23, 2022
    Copy the full SHA
    9394170 View commit details
    Browse the repository at this point in the history

  4. Removed unnecessary import

    @maneesht
    maneesht committed May 23, 2022
    Copy the full SHA
    2f82052 View commit details
    Browse the repository at this point in the history

  5. Updated test

    @maneesht
    maneesht committed May 23, 2022
    Copy the full SHA
    c976987 View commit details
    Browse the repository at this point in the history

Commits on May 24, 2022

  1. Added extra test

    @maneesht
    maneesht committed May 24, 2022
    Copy the full SHA
    fc4cf5c View commit details
    Browse the repository at this point in the history

Commits on May 25, 2022

  1. Merge branch 'master' into fix-get-cache

    @maneesht
    maneesht committed May 25, 2022
    Copy the full SHA
    7c31ece View commit details
    Browse the repository at this point in the history

  2. Fixed formatting

    @maneesht
    maneesht committed May 25, 2022
    Copy the full SHA
    3959cf3 View commit details
    Browse the repository at this point in the history

  3. Create rotten-tables-brush.md

    @maneesht
    maneesht committed May 25, 2022
    Copy the full SHA
    536e103 View commit details
    Browse the repository at this point in the history

  4. Added documentation

    @maneesht
    maneesht committed May 25, 2022
    Copy the full SHA
    3812a33 View commit details
    Browse the repository at this point in the history

  5. Passed formatting

    @maneesht
    maneesht committed May 25, 2022
    Copy the full SHA
    a8d8ea6 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2022

  1. Merge remote-tracking branch 'origin/master' into fix-get-cache

    @maneesht
    maneesht committed May 26, 2022
    Copy the full SHA
    7de3c12 View commit details
    Browse the repository at this point in the history

  2. Addressed comments

    @maneesht
    maneesht committed May 26, 2022
    Copy the full SHA
    766f46d View commit details
    Browse the repository at this point in the history

Commits on May 31, 2022

  1. WIP

    @maneesht
    maneesht committed May 31, 2022
    Copy the full SHA
    04356e4 View commit details
    Browse the repository at this point in the history

  2. Used unique id instead of foo

    @maneesht
    maneesht committed May 31, 2022
    Copy the full SHA
    a467055 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2022

  1. Used exactCount instead of Count for accumulator

    @maneesht
    maneesht committed Jun 1, 2022
    Copy the full SHA
    6145b2b View commit details
    Browse the repository at this point in the history

  2. Removed only

    @maneesht
    maneesht committed Jun 1, 2022
    Copy the full SHA
    788aaa0 View commit details
    Browse the repository at this point in the history

  3. Reformatted

    @maneesht
    maneesht committed Jun 1, 2022
    Copy the full SHA
    51d57a2 View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2022

  1. Removed get wip

    @maneesht
    maneesht committed Jun 2, 2022
    Copy the full SHA
    41a7303 View commit details
    Browse the repository at this point in the history

  2. Got minimal repro

    @maneesht
    maneesht committed Jun 2, 2022
    Copy the full SHA
    a58bb33 View commit details
    Browse the repository at this point in the history

  3. Got minimal repro

    @maneesht
    maneesht committed Jun 2, 2022
    Copy the full SHA
    5d41ce0 View commit details
    Browse the repository at this point in the history

  4. Fixed race condition issue

    @maneesht
    maneesht committed Jun 2, 2022
    Copy the full SHA
    bdfd40b View commit details
    Browse the repository at this point in the history

  5. Updated tests

    @maneesht
    maneesht committed Jun 2, 2022
    Copy the full SHA
    4ca2289 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2022

  1. Updated yarn lock file

    @maneesht
    maneesht committed Jun 3, 2022
    Copy the full SHA
    b52f468 View commit details
    Browse the repository at this point in the history

  2. Updated module type

    @maneesht
    maneesht committed Jun 3, 2022
    Copy the full SHA
    27f9ea1 View commit details
    Browse the repository at this point in the history

  3. Added comment

    @maneesht
    maneesht committed Jun 3, 2022
    Copy the full SHA
    065dab0 View commit details
    Browse the repository at this point in the history

  4. Merge remote-tracking branch 'origin/master' into fix-get-cache

    @maneesht
    maneesht committed Jun 3, 2022
    Copy the full SHA
    d5fef45 View commit details
    Browse the repository at this point in the history

  5. Removed unnecessary code

    @maneesht
    maneesht committed Jun 3, 2022
    Copy the full SHA
    74fe5e8 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2022

  1. Merge remote-tracking branch 'origin/master' into fix-get-cache

    @maneesht
    maneesht committed Jun 6, 2022
    Copy the full SHA
    5858b86 View commit details
    Browse the repository at this point in the history

  2. Removed unnecessary comment

    @maneesht
    maneesht committed Jun 6, 2022
    Copy the full SHA
    be41979 View commit details
    Browse the repository at this point in the history

  3. Removed unused imports

    @maneesht
    maneesht committed Jun 6, 2022
    Copy the full SHA
    f320a93 View commit details
    Browse the repository at this point in the history

  4. Updated test to remove redundant assertion

    @maneesht
    maneesht committed Jun 6, 2022
    Copy the full SHA
    c4f8ff7 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2022

  1. Moved query check

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    1dc798c View commit details
    Browse the repository at this point in the history

  2. Updated tests to include example queries

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    42e38f6 View commit details
    Browse the repository at this point in the history

  3. Fixed formatting

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    b4c7f28 View commit details
    Browse the repository at this point in the history

  4. Added suggestions

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    5559921 View commit details
    Browse the repository at this point in the history

  5. Fixed formatting

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    52fcf72 View commit details
    Browse the repository at this point in the history

  6. Replaced let with const

    @maneesht
    maneesht committed Jun 8, 2022
    Copy the full SHA
    c553405 View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Fixed tests

    @maneesht
    maneesht committed Jun 9, 2022
    Copy the full SHA
    a7e5865 View commit details
    Browse the repository at this point in the history

  2. Fixed test

    @maneesht
    maneesht committed Jun 9, 2022
    Copy the full SHA
    98845d1 View commit details
    Browse the repository at this point in the history

  3. Fixed formatting

    @maneesht
    maneesht committed Jun 9, 2022
    Copy the full SHA
    69feeb7 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2022

  1. Fixed tests

    @maneesht
    maneesht committed Jun 15, 2022
    Copy the full SHA
    60f9da0 View commit details
    Browse the repository at this point in the history

  2. Removed comments

    @maneesht
    maneesht committed Jun 15, 2022
    Copy the full SHA
    6f39fef View commit details
    Browse the repository at this point in the history

  3. Removed version of uuid

    @maneesht
    maneesht committed Jun 15, 2022
    Copy the full SHA
    57a8db5 View commit details
    Browse the repository at this point in the history

  4. Added a new line

    @maneesht
    maneesht committed Jun 15, 2022
    Copy the full SHA
    31a747e View commit details
    Browse the repository at this point in the history

Commits on Jun 16, 2022

  1. Addressed comments

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    bd23960 View commit details
    Browse the repository at this point in the history

  2. Extracted out uuid

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    6656e5a View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/master' into mtewani/extract-uuidv4

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    11f31f9 View commit details
    Browse the repository at this point in the history

  4. Reformatted files

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    e1318b6 View commit details
    Browse the repository at this point in the history

  5. Reformatted again

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    d79919c View commit details
    Browse the repository at this point in the history

  6. Create tame-rice-peel.md

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    5fd68d8 View commit details
    Browse the repository at this point in the history

  7. Addressed comments

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    5ee6096 View commit details
    Browse the repository at this point in the history

  8. Removed global import

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    324ce39 View commit details
    Browse the repository at this point in the history

  9. Fixed lint error

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    65234d5 View commit details
    Browse the repository at this point in the history

  10. Ran formatter

    @maneesht
    maneesht committed Jun 16, 2022
    Copy the full SHA
    199478c View commit details
    Browse the repository at this point in the history