DO NOT MERGE: Upgrade idb version from 3.2.0 to 7.0.0 #5857

hsubox76 · 2022-01-05T21:00:23Z

We had locked our idb dependency version to 3.2.0 because it was the last version to support IE. Since we no longer support IE, we can now upgrade to the most recent version which is now 7.0.0. In addition to being good practice in general, this allows us to provide ES Module versions of installations and messaging which may solve some other packaging problems for users of various frameworks.

The API has changed slightly between 3.2.0 and 7.0.0 and I've made the corresponding changes to installations/messaging code.

Also removed idb from the Renovate ignore list so we will now get Renovate PRs whenever idb is updated.

Problem about incompatibility with Node ESM mentioned in #5646 should be resolved in 7.0.0 (see jakearchibald/idb#235 (comment)). This should enable us to offer a Node ESM export in messaging, which will address #5839.

changeset-bot · 2022-01-05T21:00:27Z

🦋 Changeset detected

Latest commit: 8f26cc6

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 11 packages

Name	Type
@firebase/installations	Patch
@firebase/installations-compat	Patch
@firebase/messaging	Patch
@firebase/analytics	Patch
firebase	Patch
@firebase/performance	Patch
@firebase/remote-config	Patch
@firebase/messaging-compat	Patch
@firebase/analytics-compat	Patch
@firebase/performance-compat	Patch
@firebase/remote-config-compat	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

google-oss-bot · 2022-01-05T21:22:19Z

Size Report ¹

Affected Products

@firebase/installations
Type Base (c271d16) Merge (2b455ea) Diff
browser 17.3 kB 17.3 kB -15 B (-0.1%)
esm5 22.3 kB 22.3 kB -17 B (-0.1%)
main 23.1 kB 23.1 kB -17 B (-0.1%)
module 17.3 kB 17.3 kB -15 B (-0.1%)
@firebase/messaging
Type Base (c271d16) Merge (2b455ea) Diff
browser 20.8 kB 20.8 kB +32 B (+0.2%)
esm5 26.1 kB 26.2 kB +29 B (+0.1%)
main 26.8 kB 26.8 kB +29 B (+0.1%)
module 20.8 kB 20.8 kB +32 B (+0.2%)
@firebase/messaging-sw
Type Base (c271d16) Merge (2b455ea) Diff
module 22.8 kB 22.9 kB +32 B (+0.1%)

`bundle`

Type	Base (`c271d16`)	Merge (`2b455ea`)	Diff
analytics (logEvent)	34.7 kB	34.1 kB	-572 B (-1.7%)
messaging (send + receive)	37.8 kB	37.2 kB	-531 B (-1.4%)
performance (trace)	42.3 kB	41.7 kB	-572 B (-1.4%)
remote-config (getAndFetch)	36.7 kB	36.1 kB	-572 B (-1.6%)

`firebase`

12 size changes

Type	Base (`c271d16`)	Merge (`2b455ea`)	Diff
firebase-analytics-compat.js	26.0 kB	25.4 kB	-633 B (-2.4%)
firebase-analytics.js	107 kB	110 kB	+3.12 kB (+2.9%)
firebase-compat.js	753 kB	753 kB	-681 B (-0.1%)
firebase-messaging-compat.js	38.0 kB	37.3 kB	-650 B (-1.7%)
firebase-messaging-sw.js	102 kB	106 kB	+3.69 kB (+3.6%)
firebase-messaging.js	101 kB	104 kB	+3.69 kB (+3.7%)
firebase-performance-compat.js	30.8 kB	30.2 kB	-627 B (-2.0%)
firebase-performance-standalone-compat.es2017.js	78.9 kB	78.2 kB	-703 B (-0.9%)
firebase-performance-standalone-compat.js	57.0 kB	56.3 kB	-658 B (-1.2%)
firebase-performance.js	119 kB	122 kB	+3.12 kB (+2.6%)
firebase-remote-config-compat.js	27.5 kB	26.9 kB	-623 B (-2.3%)
firebase-remote-config.js	109 kB	112 kB	+3.12 kB (+2.9%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/ZcjMJYVRj5.html

google-oss-bot · 2022-01-05T21:34:52Z

Size Analysis Report ¹

Affected Products

@firebase/analytics
- getAnalytics
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.9 kB 28.3 kB -572 B (-2.0%)
- initializeAnalytics
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.7 kB 28.1 kB -572 B (-2.0%)
- isSupported
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.3 kB 27.7 kB -572 B (-2.0%)
- logEvent
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.1 kB 27.5 kB -572 B (-2.0%)
- setAnalyticsCollectionEnabled
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.3 kB 27.7 kB -572 B (-2.0%)
- setCurrentScreen
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.4 kB 27.8 kB -572 B (-2.0%)
- setUserId
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.4 kB 27.8 kB -572 B (-2.0%)
- setUserProperties
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.4 kB 27.9 kB -572 B (-2.0%)
- settings
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.2 kB 27.7 kB -572 B (-2.0%)
@firebase/installations
- deleteInstallations
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 8.94 kB 8.93 kB -11 B (-0.1%)
  size-with-ext-deps 18.7 kB 18.1 kB -571 B (-3.1%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  openDb
  openDB
  + openDB - openDb
- getId
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 8.38 kB 8.37 kB -11 B (-0.1%)
  size-with-ext-deps 18.1 kB 17.5 kB -571 B (-3.2%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  openDb
  openDB
  + openDB - openDb
- getInstallations
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 8.48 kB 8.47 kB -11 B (-0.1%)
  size-with-ext-deps 18.3 kB 17.7 kB -572 B (-3.1%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  openDb
  openDB
  + openDB - openDb
- getToken
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 8.39 kB 8.38 kB -11 B (-0.1%)
  size-with-ext-deps 18.1 kB 17.5 kB -571 B (-3.2%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  openDb
  openDB
  + openDB - openDb
- onIdChange
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 8.64 kB 8.63 kB -11 B (-0.1%)
  size-with-ext-deps 18.4 kB 17.8 kB -571 B (-3.1%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  openDb
  openDB
  + openDB - openDb
@firebase/messaging
- deleteToken
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 12.4 kB 12.3 kB -48 B (-0.4%)
  size-with-ext-deps 30.5 kB 29.9 kB -529 B (-1.7%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  deleteDb openDb
  deleteDB openDB
  + deleteDB + openDB - deleteDb - openDb
- getMessaging
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 12.8 kB 12.8 kB -48 B (-0.4%)
  size-with-ext-deps 31.4 kB 30.9 kB -531 B (-1.7%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  deleteDb openDb
  deleteDB openDB
  + deleteDB + openDB - deleteDb - openDb
- getToken
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 12.3 kB 12.2 kB -48 B (-0.4%)
  size-with-ext-deps 30.3 kB 29.8 kB -529 B (-1.7%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  deleteDb openDb
  deleteDB openDB
  + deleteDB + openDB - deleteDb - openDb
- isSupported
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 12.6 kB 12.5 kB -48 B (-0.4%)
  size-with-ext-deps 31.1 kB 30.5 kB -531 B (-1.7%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  deleteDb openDb
  deleteDB openDB
  + deleteDB + openDB - deleteDb - openDb
- onMessage
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size 12.4 kB 12.3 kB -48 B (-0.4%)
  size-with-ext-deps 30.5 kB 29.9 kB -529 B (-1.7%)
  External Dependency
  Module Base (c271d16) Merge (2b455ea) Diff
  idb
  deleteDb openDb
  deleteDB openDB
  + deleteDB + openDB - deleteDb - openDb
@firebase/performance
- getPerformance
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 36.2 kB 35.6 kB -572 B (-1.6%)
- initializePerformance
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 36.6 kB 36.0 kB -572 B (-1.6%)
- trace
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 36.0 kB 35.4 kB -572 B (-1.6%)
@firebase/remote-config
- activate
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.7 kB 28.2 kB -572 B (-2.0%)
- ensureInitialized
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.4 kB 27.9 kB -572 B (-2.0%)
- fetchAndActivate
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.3 kB 28.8 kB -572 B (-1.9%)
- fetchConfig
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.0 kB 28.4 kB -572 B (-2.0%)
- getAll
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.6 kB 29.0 kB -572 B (-1.9%)
- getBoolean
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.5 kB 28.9 kB -572 B (-1.9%)
- getNumber
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.4 kB 28.9 kB -572 B (-1.9%)
- getRemoteConfig
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.6 kB 28.0 kB -572 B (-2.0%)
- getString
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.4 kB 28.9 kB -572 B (-1.9%)
- getValue
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 29.4 kB 28.8 kB -572 B (-1.9%)
- isSupported
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.9 kB 28.3 kB -572 B (-2.0%)
- setLogLevel
  Size
  Type Base (c271d16) Merge (2b455ea) Diff
  size-with-ext-deps 28.6 kB 28.0 kB -572 B (-2.0%)

Test Logs

https://storage.googleapis.com/firebase-sdk-metric-reports/RpfwrJJpWQ.html

zwu52

LGTM. thanks for the upgrade & work

hsubox76 · 2022-01-18T21:10:39Z

Hold off on merging pending discussion of dropping IE support.

hsubox76 · 2023-03-17T18:21:19Z

Obsolete, we have already upgraded.

hsubox76 requested review from allspain and zwu52 January 5, 2022 21:00

hsubox76 requested review from avolkovi and yoyomyo as code owners January 5, 2022 21:00

hsubox76 removed the request for review from allspain January 5, 2022 21:01

hsubox76 assigned zwu52 Jan 6, 2022

hsubox76 requested a review from allspain January 6, 2022 18:24

hsubox76 assigned allspain Jan 6, 2022

allspain approved these changes Jan 10, 2022

View reviewed changes

hsubox76 mentioned this pull request Jan 11, 2022

Updated IDB and fixed the changes to be compatible with tools like Vite #5734

Closed

hsubox76 requested a review from egilmorez as a code owner January 11, 2022 20:13

hsubox76 added 4 commits January 11, 2022 12:16

Upgrade idb in installations

2d3c699

Upgrade idb in messaging

789053d

Remove from renovate ignore list

c99c860

Add changeset!

8f26cc6

hsubox76 force-pushed the ch-idb branch from 5b3da16 to 8f26cc6 Compare January 11, 2022 20:16

zwu52 approved these changes Jan 11, 2022

View reviewed changes

hsubox76 changed the title ~~Upgrade idb version from 3.2.0 to 7.0.0~~ DO NOT MERGE: Upgrade idb version from 3.2.0 to 7.0.0 Jan 18, 2022

hsubox76 mentioned this pull request Jan 18, 2022

Set Messaging to use only CJS bundles if Node #5901

Merged

hsubox76 closed this Mar 17, 2023

firebase locked and limited conversation to collaborators Apr 17, 2023

hsubox76 deleted the ch-idb branch May 2, 2024 18:34

DO NOT MERGE: Upgrade idb version from 3.2.0 to 7.0.0 #5857

DO NOT MERGE: Upgrade idb version from 3.2.0 to 7.0.0 #5857

Conversation

hsubox76 commented Jan 5, 2022 • edited

changeset-bot bot commented Jan 5, 2022 • edited

🦋 Changeset detected

google-oss-bot commented Jan 5, 2022 • edited

Size Report 1

Affected Products

@firebase/installations

@firebase/messaging

@firebase/messaging-sw

bundle

firebase

Test Logs

google-oss-bot commented Jan 5, 2022 • edited

Size Analysis Report 1

Affected Products

@firebase/analytics

getAnalytics

initializeAnalytics

isSupported

logEvent

setAnalyticsCollectionEnabled

setCurrentScreen

setUserId

setUserProperties

settings

@firebase/installations

deleteInstallations

getId

getInstallations

getToken

onIdChange

@firebase/messaging

deleteToken

getMessaging

getToken

isSupported

onMessage

@firebase/performance

getPerformance

initializePerformance

trace

@firebase/remote-config

activate

ensureInitialized

fetchAndActivate

fetchConfig

getAll

getBoolean

getNumber

getRemoteConfig

getString

getValue

isSupported

setLogLevel

Test Logs

zwu52 left a comment

Choose a reason for hiding this comment

hsubox76 commented Jan 18, 2022

hsubox76 commented Mar 17, 2023

hsubox76 commented Jan 5, 2022 •

edited

changeset-bot bot commented Jan 5, 2022 •

edited

google-oss-bot commented Jan 5, 2022 •

edited

Size Report ¹

`@firebase/installations`

`@firebase/messaging`

`@firebase/messaging-sw`

`bundle`

`firebase`

google-oss-bot commented Jan 5, 2022 •

edited

Size Analysis Report ¹

`@firebase/analytics`

`getAnalytics`

`initializeAnalytics`

`isSupported`

`logEvent`

`setAnalyticsCollectionEnabled`

`setCurrentScreen`

`setUserId`

`setUserProperties`

`settings`

`@firebase/installations`

`deleteInstallations`

`getId`

`getInstallations`

`getToken`

`onIdChange`

`@firebase/messaging`

`deleteToken`

`getMessaging`

`getToken`

`isSupported`

`onMessage`

`@firebase/performance`

`getPerformance`

`initializePerformance`

`trace`

`@firebase/remote-config`

`activate`

`ensureInitialized`

`fetchAndActivate`

`fetchConfig`

`getAll`

`getBoolean`

`getNumber`

`getRemoteConfig`

`getString`

`getValue`

`isSupported`

`setLogLevel`