Set Messaging to use only CJS bundles if Node #5901
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 732eb92 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected ProductsNo changes between base commit (4bd3a88) and merge commit (442feff).Test Logs |
Size Analysis Report 1Affected ProductsNo changes between base commit (4bd3a88) and merge commit (442feff).Test Logs |
zwu52
approved these changes
Jan 19, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will direct all Node consumers of messaging, messaging-compat, and messaging/sw to the respective CJS bundles, regardless of whether they are using
requireorimport. We cannot currently provide ESM Node bundles for messaging until we are able to upgrade ouridbdependency, so we need to point all Node applications to the CJS bundles.Once we are unblocked on upgrading
idb(which entails officially dropping IE support, PR #5857), we can create Node ESM bundles for messaging and separate theexports.nodeentry point intoexports.node.require(cjs) andexports.node.import(mjs) entry points.See issue #5839.