Add mockUserToken support for database emulator. #4792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuchenshi
requested review from
Feiyang1,
hiranya911,
hsubox76 and
jsdt
as code owners
🦋 Changeset detectedLatest commit: dc72577 The changes in this PR will be included in the next version bump. This PR includes changesets to release 37 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
yuchenshi
commented
Apr 15, 2021
yuchenshi
commented
Apr 15, 2021
| /* eslint-disable camelcase */ | ||
|
|
||
| describe('createMockUserToken()', () => { | ||
| it('creates a well-formed JWT', () => { |
There was a problem hiding this comment.
Migrated from an old rules unit testing library test
Size Analysis Report |
samtstern
reviewed
Apr 15, 2021
samtstern
approved these changes
Apr 15, 2021
yuchenshi
force-pushed
the
ys/mockUserToken-database
branch
from
3b35faa
to
4d8b954
Compare
Binary Size ReportAffected SDKs
Test Logs
|
schmidt-sebastian
approved these changes
Apr 22, 2021
Co-authored-by: Sebastian Schmidt <mrschmidt@google.com>
Co-authored-by: Sebastian Schmidt <mrschmidt@google.com>
Changeset File Check ✅
|
samtstern
approved these changes
Apr 28, 2021
Feiyang1
reviewed
Apr 29, 2021
Feiyang1
approved these changes
Apr 29, 2021
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
POC for new API with RTDB first.
Open questions
With this implementation, it doesn't look too challenging to support changing the mock token through repeated calls of
useEmulator(host, port, {mockUserToken})(provided thathostandportstays the same). However, there are further implications for the underlying requests (e.g. pending requests or retries). I'd prefer we have a discussion before proceeding with a separate PR.Testing
Unit testing in
@firebase/utildone, manually tested end to end for@firebase/databaseAPI Changes
Internally approved. See go/firebase-rules-unit-testing-next-api (Googlers only)