Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix database.useEmulator typing. #4870

Merged
merged 3 commits into from
May 10, 2021
Merged

Conversation

yuchenshi
Copy link
Member

Adds correct typing for new argument introduced in #4792.

@changeset-bot
Copy link

changeset-bot bot commented May 5, 2021

🦋 Changeset detected

Latest commit: f211be8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
firebase Patch
@firebase/rules-unit-testing Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

Size Analysis Report

Affected Products

No changes between base commit (62ed2bb) and head commit (c5a8cdd).

@yuchenshi yuchenshi requested a review from Feiyang1 May 5, 2021 23:42
@Feiyang1 Feiyang1 assigned yuchenshi and egilmorez and unassigned Feiyang1 and yuchenshi May 6, 2021
Copy link
Contributor

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yuchenshi yuchenshi assigned hsubox76 and unassigned egilmorez May 7, 2021
@yuchenshi yuchenshi requested a review from hsubox76 May 7, 2021 17:14
Copy link
Contributor

@hsubox76 hsubox76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved pending one thing (see comment)

packages/firebase/index.d.ts Outdated Show resolved Hide resolved
@sam-gc sam-gc merged commit cc7207e into master May 10, 2021
@sam-gc sam-gc deleted the ys/database-useEmulator-typing branch May 10, 2021 20:42
@google-oss-bot google-oss-bot mentioned this pull request May 11, 2021
@firebase firebase locked and limited conversation to collaborators Jun 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants