Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Directly initialize properties in UserMetadata #803

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Directly initialize properties in UserMetadata #803

wants to merge 5 commits into from

Commits on Mar 6, 2020

  1. Directly initialize properties in UserMetadata 

    Prompted by attempting to enable tsconfig options
'strictPropertyInitialization'.

The properties were being indirectly set via Object.defineProperty.
Typescript isn't able to follow that. Setting the properties directly
resolves it. (And also exposed some minor type errors.)
    @rsgowman
    rsgowman committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    19d08d7 View commit details
    Browse the repository at this point in the history

  2. review feedback

    @rsgowman
    rsgowman committed Mar 6, 2020
    Configuration menu
    Copy the full SHA
    1f81e99 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2020

  1. review feedback 2

    @rsgowman
    rsgowman committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    ffb9cc7 View commit details
    Browse the repository at this point in the history

  2. Merge remote-tracking branch 'origin/master' into rsgowman/strictProp… 

    …ertyInitialization_investigation
    @rsgowman
    rsgowman committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    db82791 View commit details
    Browse the repository at this point in the history

  3. review feedback 3

    @rsgowman
    rsgowman committed Mar 9, 2020
    Configuration menu
    Copy the full SHA
    3fbeecd View commit details
    Browse the repository at this point in the history