Directly initialize properties in UserMetadata #803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prompted by attempting to enable tsconfig options 'strictPropertyInitialization'. The properties were being indirectly set via Object.defineProperty. Typescript isn't able to follow that. Setting the properties directly resolves it. (And also exposed some minor type errors.)
rsgowman
commented
Mar 6, 2020
hiranya911
suggested changes
Mar 6, 2020
hiranya911
approved these changes
Mar 7, 2020
| @@ -491,13 +491,12 @@ declare namespace admin.auth { | |||
| /** | |||
| * The date the user last signed in, formatted as a UTC string. | |||
| */ | |||
| lastSignInTime: string; | |||
| lastSignInTime: string | null; | |||
There was a problem hiding this comment.
Nit: Let's also update the doc comment to indicate when these values are null.
There was a problem hiding this comment.
Done. Though note that there's not a great explanation as to why creationTime might be null. As an alternative, we could keep it as non-nullable and change the implementation to throw an internal error if this situation occurs.
There was a problem hiding this comment.
That sounds like the right approach to me.
There was a problem hiding this comment.
Done. A number of unit tests needed to be changed as a result. I think the changes are correct, but definitely will want Bassam to weigh in on this too.
…ertyInitialization_investigation
hiranya911
approved these changes
Mar 9, 2020
| @@ -491,13 +491,12 @@ declare namespace admin.auth { | |||
| /** | |||
| * The date the user last signed in, formatted as a UTC string. | |||
| */ | |||
| lastSignInTime: string; | |||
| lastSignInTime: string | null; | |||
There was a problem hiding this comment.
That sounds like the right approach to me.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prompted by attempting to enable tsconfig options
'strictPropertyInitialization'.
The properties were being indirectly set via Object.defineProperty.
Typescript isn't able to follow that. Setting the properties directly
resolves it. (And also exposed some minor type errors.)