update go-sectorbuilder and golangci-lint #3650
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frrist
force-pushed
the
fix/update-golangci-lint
branch
from
b461ced
to
1847d79
Compare
Codecov Report
@@ Coverage Diff @@
## master #3650 +/- ##
======================================
- Coverage 47% 47% -1%
======================================
Files 270 270
Lines 17227 17227
======================================
- Hits 8155 8147 -8
- Misses 7968 7973 +5
- Partials 1104 1107 +3 |
|
@acruikshank can you confirm this builds/WAE on your computer, sometimes CI gives false positives on changes like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
After updating to go 1.13 there have been some issues with go mod and the package/version: github.com/golangci/golangci-lint v1.17.1.
see for more details #3488 (comment)
Proposed changes
This PR updates go-filecoin to use github.com/golangci/golangci-lint v1.21.0 and also updates go-sectorbilder to a commit with the same linter version