Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract dropdown #3443

Merged
merged 24 commits into from Aug 30, 2022
Merged

Extract dropdown #3443

merged 24 commits into from Aug 30, 2022

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Aug 9, 2022 •
edited

  • Update docs about configuring scripts
  • Dropdown panel width
  • Dropdown border opacity

@zepfietje zepfietje added the enhancement New feature or request label Aug 9, 2022
@jojostx

This comment was marked as resolved.

Sign in to view
@zepfietje

This comment was marked as resolved.

Sign in to view
@zepfietje zepfietje mentioned this pull request Aug 10, 2022
Merged
@zepfietje zepfietje mentioned this pull request Aug 19, 2022
Closed
@danharrin danharrin linked an issue Aug 19, 2022 that may be closed by this pull request
Filter PopOver goes off screen in Mobile devices (sm and small under 450px) #3418
Closed
@danharrin

This comment was marked as resolved.

Sign in to view
@zepfietje

This comment was marked as resolved.

Sign in to view
@zepfietje zepfietje marked this pull request as ready for review August 22, 2022 17:06
@danharrin
Copy link
Member

Merge conflicts

@zepfietje
Copy link
Member Author

Merge conflicts

Resolved!

@zepfietje zepfietje mentioned this pull request Aug 29, 2022
Closed
danharrin
danharrin requested changes Aug 30, 2022
View reviewed changes
Copy link
Member

@danharrin danharrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You will need to revert all asset changes before I can merge this

@zepfietje
Copy link
Member Author

You will need to revert all asset changes before I can merge this

Yeah, so want to keep Alpine Floating UI shipped with the forms package? And what about the others, should they have docs to manually add it, since it wasn't there now?

@danharrin
Copy link
Member

Floating UI is used by the forms package

Tables and admin require the forms package already

So no extra docs needed, just keep this PR as a refactor to a common dropdown Blade component.

@zepfietje
Copy link
Member Author

I've got a separate PR to add action groups support to the notifications package. So how should that be handled then?

@zepfietje
Copy link
Member Author

You will need to revert all asset changes before I can merge this

Resolved, @danharrin!

@danharrin danharrin merged commit ea3e602 into 2.x Aug 30, 2022
@zepfietje zepfietje deleted the extract-dropdown branch August 30, 2022 21:09
@ksassnowski ksassnowski mentioned this pull request Aug 31, 2022
Closed
@danharrin danharrin mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danharrin danharrin Awaiting requested review from danharrin

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Filter PopOver goes off screen in Mobile devices (sm and small under 450px)
3 participants
@zepfietje @jojostx @danharrin