Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support action groups in notifications #3454

Merged
merged 3 commits into from Aug 30, 2022
Merged

Support action groups in notifications #3454

merged 3 commits into from Aug 30, 2022

Conversation

zepfietje
Copy link
Member

@zepfietje zepfietje commented Aug 10, 2022 •
edited

No description provided.

@zepfietje zepfietje changed the title Notifications action group Support action groups in notifications Aug 10, 2022
@zepfietje zepfietje added the enhancement New feature or request label Aug 10, 2022
@zepfietje

This comment was marked as resolved.

Sign in to view
@zepfietje zepfietje marked this pull request as ready for review August 30, 2022 21:15
@zepfietje
Copy link
Member Author

@danharrin, before merging we need to discuss #3443 (comment).

@danharrin
Copy link
Member

Because this is a new feature, we can just add the Floating UI package installation to the install docs.

@zepfietje
Copy link
Member Author

Because this is a new feature, we can just add the Floating UI package installation to the install docs.

Fair.

@zepfietje
Copy link
Member Author

Updated, @danharrin.

@danharrin
Copy link
Member

Ready to merge?

@zepfietje
Copy link
Member Author

Ready to merge?

Think so. 👀

@danharrin danharrin merged commit d02cbfa into 2.x Aug 30, 2022
@danharrin danharrin deleted the notifications-action-group branch August 30, 2022 22:03
danharrin added a commit that referenced this pull request Aug 31, 2022
@danharrin
Revert "Merge pull request #3454 from filamentphp/notifications-actio…
dee193f 
…n-group"

This reverts commit d02cbfa, reversing
changes made to 83409d9.
danharrin added a commit that referenced this pull request Aug 31, 2022
@danharrin
Revert "Revert "Merge pull request #3454 from filamentphp/notificatio…
83f4205 
…ns-action-group""

This reverts commit dee193f.
@danharrin danharrin mentioned this pull request Aug 31, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@zepfietje @danharrin