Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A few fixes for the test Makefile #754

Merged
merged 2 commits into from
Mar 27, 2020
Merged

A few fixes for the test Makefile #754

merged 2 commits into from
Mar 27, 2020

Commits on Mar 25, 2020

  1. Remove MACOSX_DEPLOYMENT_TARGET in FFI Makefile 

    * It causes `ld: library not found for -lgcc_s.10.4` in CI on Mojave.
* Add -Wno-unused-parameter to silence warnings.
* Do not try to compile 32-bit as that is warned:
  ld: warning: The i386 architecture is deprecated for macOS (remove from the Xcode build setting: ARCHS)
    @eregon
    eregon committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    40383fe View commit details
    Browse the repository at this point in the history

  2. Always call make for FFI specs 

    * The fact that the library exists doesn't mean it's up to date.
* The Makefile does the right timestamp checks and compares to sources, and it's fast.
* Simplify code, `system` returns false or nil when the command fails.
    @eregon
    eregon committed Mar 25, 2020
    Configuration menu
    Copy the full SHA
    13e8ab6 View commit details
    Browse the repository at this point in the history