A few fixes for the test Makefile #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* It causes `ld: library not found for -lgcc_s.10.4` in CI on Mojave. * Add -Wno-unused-parameter to silence warnings. * Do not try to compile 32-bit as that is warned: ld: warning: The i386 architecture is deprecated for macOS (remove from the Xcode build setting: ARCHS)
* The fact that the library exists doesn't mean it's up to date. * The Makefile does the right timestamp checks and compares to sources, and it's fast. * Simplify code, `system` returns false or nil when the command fails.
|
The CI seems partially broken and it looks unrelated to this PR 😢 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commit messages for details.
Part of #660 (comment)