#360: Fix solaris 10 match so it doesn't match solaris 11 #391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'solaris2.11' =~ /solaris(!?2\.11)/ will return 0, which in ruby is true, not false so std=c99 is still showing up on solaris 11.
face
changed the title
|
Any update on this pull request? This also effects installing ffi on SmartOS. |
|
+1 to fixing this :) |
|
This pull request overlaps with #382, fixing the same issue. Can we get consensus on which one should be merged? |
|
Please try #399 as a fix for this. |
|
I will try this fix on SmartOS as soon as I can. Sent from my iPhone
|
|
Tested and working on SmartOS |
|
+1 to fixing this - what can I do to help? |
|
bump 😃 |
|
Would pulling this flag from RbConfig work? I don't have a Solaris box to test this properly yet. What do I need to install in a VM to replicate your environment? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'solaris2.11' =~ /solaris(!?2.11)/ will return 0, which in ruby is true, not false so std=c99 is still showing up on solaris 11.