#360: Use correct compiler flag when using Solaris Studio. #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, allow compiler flag to be set for older/newer versions of Solaris. Admittedly, it is a bit of a preemtive strike for later versions.
|
This pull request overlaps with #391, fixing the same issue. Can we get consensus on which one should be merged? |
|
Please try #399 as a fix for this. |
|
Tested and working on SmartOS |
|
Would pulling this flag from RbConfig work? I don't have a Solaris box to test this properly yet. What do I need to install in a VM to replicate your environment? |
|
@tduehr You can use vagrant to start a smartos vm (https://app.vagrantup.com/joyent) or you can run a container instance in Joyent's cloud (https://www.joyent.com/). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will also allow compiler flag to be set for older/newer versions of Solaris. Admittedly, it is a bit of a preemptive strike for later versions.
This should help with issue #360.