Fix multi-parameter println spacing #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`fmt.Println` will add spaces between elements when there is multiple parameters sent. When wrapping the colors parameters were combined using `fmt.Sprint(a...)` - which does not space out parameters. Use `fmt.Sprintln` to combine parameters. Fixes fatih#218
|
Thank you @klauspost for the fix. How important is a release for you? I was planning to wait a few weeks before releasing a new version. |
|
@fatih Not very, as it is cosmetic. I can always pin the master commit. Feel free to keep it for the RGB release. |
|
Got it, thank you again. Feel free to ping me If I forgot the release. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fmt.Printlnwill add spaces between elements when there is multiple parameters sent. This is also described in the documentation of this library:Spaces are always added between operands and a newline is appended.When wrapping the colors parameters were combined using
fmt.Sprint(a...)- which does not space out parameters.Use
fmt.Sprintlnto combine parameters.Fixes #218