analysis: add space before printing filename #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the output looks like: ``` Aggregated data saved toFILENAME.txt ``` There should be a space after 'to', so that's what this PR adds.
|
Println should already add spaces. See output from Seems to be an issue with the terminal color printer. |
|
I've proposed an upstream fix here: fatih/color#228 |
klauspost
requested changes
Apr 8, 2024
There was a problem hiding this comment.
You can change the go.mod to point to the commit with the fix.
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the output when specifying
--analyze.outlooks like:There should be a space after 'to', so that's what this PR adds.