feat: fastly.sdkVersion implementation #776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elliottt as discussed today, I've renamed this to |
guybedford
changed the title
elliottt
approved these changes
May 11, 2024
| @@ -32,6 +32,8 @@ const JSErrorFormatString js_ErrorFormatString[JSErrNum_Limit] = { | |||
|
|
|||
| #include "host_interface/host_api.h" | |||
|
|
|||
| #define RUNTIME_VERSION "3.13.2-dev" | |||
There was a problem hiding this comment.
We talked about this briefly earlier, but it would be great to figure out how to get release-please to keep this in sync.
There was a problem hiding this comment.
Will follow up as soon as I've worked out the release process.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implements a new
fastly.sdkVersionproperty as well as an equivalentimport { sdkVersion } from 'fastly:experimental'version property.This is immediately useful in the StarlingMonkey builds to be able to easily inspect if we are in a StarlingMonkey build by checking
fastly.sdkVersion === 'starlingmonkey-dev', which allows smoothing over any test handling edge cases more easily.It's included in the types as a hidden property that is experimental. The engine build for the main runtime is set to the next patch version with a
-devsuffix.We will need to ensure we update this definition for each version release.
Resolves #775.