Simple cache StarlingMonkey port #772
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guybedford
force-pushed
the
simple-cache
branch
4 times, most recently
from
a73bd4b
to
59516a6
Compare
elliottt
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ports the simple cache subsystem. This does not yet port core cache so the
fastly:cachenamespace remains incomplete.A CI matrix is added for testing both
varnishandcomputeplatforms for StarlingMonkey, so that this can be properly tested.As with the cache override PR, the "SimpleCache.x is not a constructor" error messages become
(intermediate value).x is not a constructorerrors due to the nature of the ESM builtins, but will still point to the correct JS source position for debugging.This uses StarlingMonkey from bytecodealliance/StarlingMonkey#43, thanks to @lpereira for helping figure out the OpenSSL CMake dependency here.
This is also based to #776 to allow the StarlingMonkey e2e tests to run simultaneously with the runtime ones, by using distinct kv store names.