Reorder Generic Types of FastifyReply

[sceccotti89]

Issue: #4414

I didn't feel the need to write new tests since we are just reordering reply types.

Checklist

• run npm run test and npm run benchmark
• tests and/or benchmarks are included
• documentation is changed or added
• commit message and code follows the Developer's Certification of Origin
  and the Code of conduct

[mcollina]

What does @fastify/typescript think of this change?

[climba03003]

Re-order is good, but it is not safe to land in main.

[sceccotti89]

I do agree on that because it might be a breaking change. If you may suggest a different destination branch I'm more than willing to change it.

[climba03003]

You can target to next branch.

[sceccotti89]

Thanks @climba03003 for the feedback. Target branch changed to next.

[Uzlopak]

I changed the title to express better what this PR is doing.

[climba03003]

Can you rebase again. It included other commit in your PR.

[sceccotti89]

@climba03003 I've been finally able to rebase the pull request. Sorry but I don't feel comfortable with rebasing.

[climba03003]

Sorry but I don't feel comfortable with rebasing.

I usually use GUI for rebasing, command would be too complicated if you don't familiar with git.

[sceccotti89]

@climba03003 I don't want to go off-topic, but I'd like to know more about the GUI you're using (is it tortoise, perhaps?). I normally use this command git rebase -i HEAD~<number> but, as you said, it's not always user friendly (especially if there has been a merge).

[climba03003]

@climba03003 I don't want to go off-topic, but I'd like to know more about the GUI you're using (is it tortoise, perhaps?). I normally use this command git rebase -i HEAD~<number> but, as you said, it's not always user friendly (especially if there has been a merge).

I use git fork. You need to use --onto if you want to change the base branch.

[sceccotti89]

@climba03003 Thanks for the info, I'll take a look.
Btw, tests failed. According to logs it should not be related to my latest changes 🙄

[Uzlopak]

@climba03003
can you please add the commits from master to next to have the latest fixes regarding node19 and tap 16.3.1 issues?

[Uzlopak]

Uff, I think this also means that all plugins, which decorate fastifyReply need changes.