CI workflow is failing for node 14 on windows-latest

[driimus]

Prerequisites

• I have written a descriptive issue title
• I have searched existing issues to ensure the issue has not already been raised

Issue

Only raising the issue for visibility. Feel free to close if there's already a planned resolution.

fastify/.github/workflows/ci.yml

Line 1 in 5c8039c

name: ci

This workflow (or any others that use npm@<7 and the latest tap version) will fail for node 14 on windows-latest.
Context and workarounds: fastify/fastify-type-provider-typebox#43 (comment)

You can see newer PRs experience the failure (e.g. #4415, #4421)

[jsumners]

In each instance where that workflow uses a specific Node.js version it is lts/*, except for line:

fastify/.github/workflows/ci.yml

Line 75 in 5c8039c

node-version: [14, 16, 18, 19]

None of those versions ship with npm@9.

[climba03003]

More like an upstream issue.
fastify > tap > @babel/generator > @jridgewell/gen-mapping

[Uzlopak]

I actually dont understand why this really happens because @isaacs puts all the dependencies also in the final tar file which gets pushed to npm.

[climba03003]

Is it possible to push the node_modules to npm.js?
This folder should be ignored in any configuration.

Interesting, it is packed inside.

[Uzlopak]

This happens because of bundleDependencies field in the package.json.

[climba03003]

I see the old issue tapjs/tapjs#620

[Uzlopak]

Maybe the bundled dependencies need to be part of devDependencies to avoid issues, when npm tries to overwrite them in the installation phase of the dependencies?

[Uzlopak]

Isaacs released new tap version..we have to trigger the workflows again