Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if route exist before checking Content-Type of body #4286

Merged
merged 5 commits into from Sep 18, 2022
Merged

Check if route exist before checking Content-Type of body #4286

merged 5 commits into from Sep 18, 2022

Commits on Sep 17, 2022

  1. check if route exist before checking content type

    @mage1k99
    mage1k99 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    7e349ab View commit details
    Browse the repository at this point in the history

  2. added test for route check before content type

    @mage1k99
    mage1k99 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    3151fe5 View commit details
    Browse the repository at this point in the history

  3. pass tests 

    - check if the route is 404 only if the content-parser is undefined
by this we can avoid breaking changes.
- this also passes previous tests

this resolves issue
- fastify/fastify-multipart#381
    @mage1k99
    mage1k99 committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    00e0f66 View commit details
    Browse the repository at this point in the history

  4. Update lib/contentTypeParser.js 

    Noted, thanks for the review

Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
    @mage1k99 @Eomm
    mage1k99 and Eomm committed Sep 17, 2022
    Configuration menu
    Copy the full SHA
    7b9bd3b View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2022

  1. pass tests from wrong return

    @mage1k99
    mage1k99 committed Sep 18, 2022
    Configuration menu
    Copy the full SHA
    7ec52a1 View commit details
    Browse the repository at this point in the history