Check if route exist before checking Content-Type of body #4286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
2 tasks
|
Cant we check before we run the content type parser if we havea 404? |
Yes that is possible. I checked with the tests. seems like I was bit wrong in understanding the comment. |
- check if the route is 404 only if the content-parser is undefined by this we can avoid breaking changes. - this also passes previous tests this resolves issue - fastify/fastify-multipart#381
|
I have updated the check. thanks to @Uzlopak for giving me hint All the tests now passes |
Eomm
reviewed
Sep 17, 2022
Noted, thanks for the review Co-authored-by: Manuel Spigolon <behemoth89@gmail.com>
Eomm
approved these changes
Sep 18, 2022
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
npm run testandnpm run benchmarkand the Code of conduct